New issue
Advanced search Search tips

Issue 744223 link

Starred by 1 user
Status: Assigned
Owner: ----
Cc:
yyushkina@chromium.org
anthonyvd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

translate_ui_delegate is missing unit tests

Project Member Reported by napper@chromium.org, Jul 17 2017 
From ftang@:
Currently this file only test TranslationDeclined(), we
need to add the test for other functions soon to increase the test
coverage.

This will become an issue when we start the new transation UI work.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04f14d7d8e8cf7a2fc140a0bdc491953a008942a

commit 04f14d7d8e8cf7a2fc140a0bdc491953a008942a
Author: Jon Napper <napper@chromium.org>
Date: Tue Jul 18 06:31:54 2017

Added missing unit tests for translate_ui_delegate

Added missing unit tests for translate_ui_delegate. Also added
missing EXPECT_CALL()s for RecordTranslationEvents.

Bug: 744223
Change-Id: Id78a230a8faa59295a58e13771401e7c989b4993
Reviewed-on: https://chromium-review.googlesource.com/572507
Reviewed-by: David Vallet <dvallet@chromium.org>
Commit-Queue: Jon Napper <napper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487397}
[modify] https://crrev.com/04f14d7d8e8cf7a2fc140a0bdc491953a008942a/components/translate/core/browser/mock_translate_driver.cc
[modify] https://crrev.com/04f14d7d8e8cf7a2fc140a0bdc491953a008942a/components/translate/core/browser/mock_translate_driver.h
[modify] https://crrev.com/04f14d7d8e8cf7a2fc140a0bdc491953a008942a/components/translate/core/browser/translate_ui_delegate.h
[modify] https://crrev.com/04f14d7d8e8cf7a2fc140a0bdc491953a008942a/components/translate/core/browser/translate_ui_delegate_unittest.cc

Comment 2 by napper@chromium.org, Feb 5 2018

Owner: ----

Comment 3 by yyushkina@chromium.org, Mar 7 2018

Cc: yyushkina@chromium.org anthonyvd@chromium.org
Jon - looks like you added some unit tests. Are more needed?

Comment 4 by yyushkina@chromium.org, Mar 7 2018

Labels: -Pri-2 Pri-3
►

Sign in to add a comment