New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 744215 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Sep 2017
Cc:
calamity@chromium.org
█ chiaravanone@chromium.org
kkaluri@chromium.org
█ dimu@chromium.org
songsuk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add presubmit to prevent mixing of old-style placeholders with ICU placeholders

Project Member Reported by calamity@chromium.org, Jul 17 2017 
See  Issue 741195 .

A translation plural string that was uploaded in ICU format included a $1 style placeholder. This was not handled well by the translation console system, resulting in translations that excluded the $1 placeholder, resulting in broken translation builds.

To prevent a similar situation in future, either the translation console should change and keep the $1 placeholder that was originally there, or we should prevent mixing $1 placeholders into ICU strings at CL upload time via a PRESUBMIT.

Comment 1 by mencinares@google.com, Aug 18 2017 

Hi,

We can see that this issue has been fixed already on the same case that you've indicated in this thread. May we know if there is still some issue here that needs to be checked?

Kind Regards,
Marvin

Comment 2 by calamity@chromium.org, Aug 25 2017 

There should be a PRESUBMIT that prevents this issue from occurring again.

Comment 3 by mencinares@google.com, Sep 5 2017

Labels: Needs-TestConfirmation
Status: Unconfirmed (was: Untriaged)
Hi,

This is not a localization bug. Unable to confirm that it's still relevant to the current English UI.

Regards!

Comment 4 by kkaluri@chromium.org, Sep 13 2017

Cc: kkaluri@chromium.org
Labels: Needs-Feedback
calamity@ Could you please help us with repro steps or html test case to test the issue from TE end.

Thank You...

Comment 5 by calamity@chromium.org, Sep 15 2017

Labels: -Needs-TestConfirmation -Needs-Feedback
Status: WontFix (was: Unconfirmed)
I'm guessing nobody has cycles to fix this.
►

Sign in to add a comment