New issue
Advanced search Search tips

Issue 744129 link

Starred by 0 users
Status: WontFix
Owner:
yosin@chromium.org
Closed: Jul 2017
Cc:
yosin@chromium.org
johnchen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

29.2% regression in media.tough_video_cases at 482357:482496

Project Member Reported by zhanliang@google.com, Jul 16 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 16 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=744129

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d79cffc6953f356ed002bb291b7f25d29c24bfc90195b2c940c753c2faea72b6


Bot(s) for this bug's original alert(s):

linux-release
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 16 2017

Cc: yosin@chromium.org
Owner: yosin@chromium.org

=== Auto-CCing suspected CL author yosin@chromium.org ===

Hi yosin@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : yosin
  Commit : 5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377
  Date   : Tue Jun 27 01:29:55 2017
  Subject: Make Position::LastPositionInNode() to take const Node& instead of Node*

Bisect Details
  Configuration: linux_perf_bisect
  Benchmark    : media.tough_video_cases
  Metric       : seek/video.html?src_garden2_10s.webm_seek
  Change       : 6.75% | 173.164642857 -> 163.715714286

Revision             Result                  N
chromium@482356      173.165 +- 27.3179      14      good
chromium@482428      174.814 +- 28.1909      14      good
chromium@482462      173.535 +- 40.3486      21      good
chromium@482478      177.324 +- 41.8496      14      good
chromium@482488      176.184 +- 33.6005      14      good
chromium@482492      175.147 +- 44.0595      21      good
chromium@482494      176.112 +- 35.6025      14      good
chromium@482495      181.369 +- 28.573       6       good
chromium@482496      163.716 +- 39.5246      14      bad       <--

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.garden2.10s.webm.seek media.tough_video_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973894324392133856


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 17 2017

Labels: Hotlist-Google

Comment 5 by yosin@chromium.org, Jul 18 2017

Status: WontFix (was: Untriaged)
My patch mentioned in #c3 change a parameter type to |Node*| to |const Node&|,
I don't think this causes speed regression.

Comment 9 by yosin@chromium.org, Jul 18 2017 

The regression graphs say "lower is better", so, 173.1 -> 163.7 means result is
better than before.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Jul 18 2017 


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: linux_perf_bisect
  Benchmark    : media.tough_video_cases
  Metric       : seek/tulip2.vp9.webm_seek_warm

Revision             Result                  N
chromium@482356      74.8919 +- 14.8341      21      good
chromium@482496      74.0502 +- 15.0829      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests media.tough_video_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973751168566817040


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Jul 18 2017 


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: linux_perf_bisect
  Benchmark    : media.tough_video_cases
  Metric       : seek/garden2_10s.webm_seek_warm

Revision             Result                  N
chromium@482356      171.79 +- 42.4684       21      good
chromium@482496      175.177 +- 48.3082      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests media.tough_video_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973751144034085680


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Jul 18 2017 


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: linux_perf_bisect
  Benchmark    : media.tough_video_cases
  Metric       : seek/video.html?src_garden2_10s.webm_seek

Revision             Result                  N
chromium@482356      177.959 +- 49.9999      21      good
chromium@482496      175.934 +- 39.1773      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.garden2.10s.webm.seek media.tough_video_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973751130199054416


For feedback, file a bug with component Speed>Bisection
►

Sign in to add a comment