New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 743565 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Sep 2017
Cc:
█ krajshree@chromium.org
thomasanderson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

use_gtk3 should be removed

Reported by pdk...@gmail.com, Jul 15 2017 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.68 Safari/537.36

Steps to reproduce the problem:
Now that GTK3 is default, any GTK3-only code does not appear to be put in #if anymore, with the consequence that disabling the flag causes Chrome to not compile. So the flag is pointless, as is GTK2-only code I think.

An example CL.

https://chromium.googlesource.com/chromium/src/+/b50cab37a165f1f11d9a046d7f3367e4a563a73f

What is the expected behavior?

What went wrong?
^

Did this work before? Yes 

Chrome version: 60.0.3112.68  Channel: beta
OS Version: Ubuntu 14.04
Flash Version:

Comment 1 by krajshree@chromium.org, Jul 18 2017

Cc: krajshree@chromium.org
Components: UI>Browser>Themes
Labels: Needs-Feedback
pdknsk@ - Thanks for filing the issue...!!

Could you please provide a consistent reproducible steps with expected and actual results to triage the issue from TE-end.

Thanks...!!

Comment 2 by ranjitkan@chromium.org, Jul 26 2017

Labels: Needs-Triage-M60

Comment 3 by thestig@chromium.org, Aug 24 2017

Cc: thomasanderson@chromium.org
Components: -UI>Browser>Themes Internals>PlatformIntegration
Labels: -Pri-2 -Needs-Feedback -Needs-Triage-M60 Pri-3

Comment 4 by kkaluri@chromium.org, Sep 20 2017

Labels: Needs-Feedback Needs-Milestone
pdknsk@ Could you please respond to the Comment #1

Comment 5 by thomasanderson@chromium.org, Sep 20 2017

Status: WontFix (was: Unconfirmed)
I have received complaints about the GTK2 build being broken (which we have fixed), so there are apparently still folks who build in that configuration.  Lets not remove the GTK2 code for a little while longer.
►

Sign in to add a comment