Debug builder consistently fails to compile |
|||||||
Issue descriptionThe Fuchsia (dbg) builder consistently fails to compile //ui/gfx. We should fix it (possibly by stopping compiling some targets on it until we need them) and add a gatekeeper config to inform us when it breaks again.
,
Jul 15 2017
,
Jul 15 2017
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/324443a60943a320dc0074bdd8b4b1524493166d commit 324443a60943a320dc0074bdd8b4b1524493166d Author: Scott Graham <scottmg@chromium.org> Date: Mon Jul 31 23:08:42 2017 fuchsia: Stub a few functions to get Debug linking AmountOfAvailablePhysicalMemoryImpl isn't currently implementable as there's no system call for it. The GPU collection ones, there's no GPU access set up yet at all. Bug: 706592, 707031, 743296 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib161bf45120ff13127ad198d57017ffc6d7c9a79 Reviewed-on: https://chromium-review.googlesource.com/592642 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490815} [modify] https://crrev.com/324443a60943a320dc0074bdd8b4b1524493166d/base/sys_info_fuchsia.cc [modify] https://crrev.com/324443a60943a320dc0074bdd8b4b1524493166d/gpu/config/BUILD.gn [add] https://crrev.com/324443a60943a320dc0074bdd8b4b1524493166d/gpu/config/gpu_info_collector_fuchsia.cc
,
Aug 1 2017
,
Aug 1 2017
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed94274a052f593ac5f2d37cc705ede6c07a099c commit ed94274a052f593ac5f2d37cc705ede6c07a099c Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 02 16:02:29 2017 fuchsia: Implement base::SharedMemory::GetHandleLimit() There's no documented handle limit on Fuchsia, and it looks like this function is used for questionable purposes anyway, so just return ::max(). Bug: 743296 Change-Id: I4e85f31eb519d5dc2d96882d793b9e2c4afc7851 Reviewed-on: https://chromium-review.googlesource.com/597008 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491387} [modify] https://crrev.com/ed94274a052f593ac5f2d37cc705ede6c07a099c/base/memory/shared_memory_fuchsia.cc
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8590523e8d1b7918834e0b19b2ea2c1a31813c8a commit 8590523e8d1b7918834e0b19b2ea2c1a31813c8a Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 02 18:08:53 2017 fuchsia: Stub Screen Fuchsia is initially trying to get a headless build up and running so a full Screen implementation is unnecessary, other than to be able to link. Bug: 750946 , 743296 Change-Id: Ib6333a304deacbd22d3f1b1f3af8fc9ca063bb15 Reviewed-on: https://chromium-review.googlesource.com/596949 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491436} [modify] https://crrev.com/8590523e8d1b7918834e0b19b2ea2c1a31813c8a/ui/display/BUILD.gn [add] https://crrev.com/8590523e8d1b7918834e0b19b2ea2c1a31813c8a/ui/display/screen_fuchsia.cc
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cea99f6eb3b6e67579771bee0c9b5a231007dd22 commit cea99f6eb3b6e67579771bee0c9b5a231007dd22 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 02 18:36:51 2017 fuchsia: stub ui/base/cursor/cursor_loader Fuchsia is initially trying to get a headless build up and running so cursors are unnecessary. Bug: 743296 Change-Id: Ia2093400215a00f8dabfbd1365baa4b5f58a556b Reviewed-on: https://chromium-review.googlesource.com/596950 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491449} [modify] https://crrev.com/cea99f6eb3b6e67579771bee0c9b5a231007dd22/ui/base/BUILD.gn [modify] https://crrev.com/cea99f6eb3b6e67579771bee0c9b5a231007dd22/ui/base/cursor/cursor_loader.h [add] https://crrev.com/cea99f6eb3b6e67579771bee0c9b5a231007dd22/ui/base/cursor/cursor_loader_fuchsia.cc
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a554e3a7c070e2648eb62dc2f6a1aa939525ef9f commit a554e3a7c070e2648eb62dc2f6a1aa939525ef9f Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 02 18:43:47 2017 fuchsia: Stub ui/base/idle Fuchsia is initially trying to get a headless build up and running so idle detection is unnecessary. Bug: 743296 Change-Id: I497f42d533e853ce397eeae3ced19a490742c0ee Reviewed-on: https://chromium-review.googlesource.com/596505 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491450} [modify] https://crrev.com/a554e3a7c070e2648eb62dc2f6a1aa939525ef9f/ui/base/BUILD.gn [add] https://crrev.com/a554e3a7c070e2648eb62dc2f6a1aa939525ef9f/ui/base/idle/idle_fuchsia.cc
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b054ab43b2333ad22aff0a43bd79cf1467af414b commit b054ab43b2333ad22aff0a43bd79cf1467af414b Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 02 22:36:00 2017 fuchsia: Stub some unneeded gfx methods Fuchsia is initially trying to get a headless build up and running so gpu methods are unnecessary. Bug: 743296 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5acc71a1be7b2058538a9e0d8d2bef4ba3ca4a52 Reviewed-on: https://chromium-review.googlesource.com/596506 Reviewed-by: John Bauman <jbauman@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491532} [modify] https://crrev.com/b054ab43b2333ad22aff0a43bd79cf1467af414b/gpu/config/gpu_info_collector_fuchsia.cc [modify] https://crrev.com/b054ab43b2333ad22aff0a43bd79cf1467af414b/gpu/ipc/service/BUILD.gn [add] https://crrev.com/b054ab43b2333ad22aff0a43bd79cf1467af414b/gpu/ipc/service/image_transport_surface_fuchsia.cc
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c53b12be9d8c9de33d6e59e2b0bbf51d336d96f commit 0c53b12be9d8c9de33d6e59e2b0bbf51d336d96f Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 11 17:33:23 2017 fuchsia: repair debug/component compilation after switching use_aura on This is fallout from switching Aura on for Fuchsia in https://chromium.googlesource.com/chromium/src.git/+/6b90efc3352fcc6d9a6160fb39232ad26fad1659. We can use the generic Aura implementations (at least for stubs) rather than having _fuchsia-specific stubs. Bug: 743296 , 746674 Change-Id: I6ff96cbacc4fef54a1a1390288d57bb5b1dfcc7d Reviewed-on: https://chromium-review.googlesource.com/611412 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#493785} [modify] https://crrev.com/0c53b12be9d8c9de33d6e59e2b0bbf51d336d96f/ui/base/BUILD.gn [delete] https://crrev.com/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d/ui/base/clipboard/clipboard_fuchsia.cc [delete] https://crrev.com/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d/ui/base/clipboard/clipboard_fuchsia.h [delete] https://crrev.com/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d/ui/base/cursor/cursor_loader_fuchsia.cc [modify] https://crrev.com/0c53b12be9d8c9de33d6e59e2b0bbf51d336d96f/ui/base/ime/BUILD.gn [modify] https://crrev.com/0c53b12be9d8c9de33d6e59e2b0bbf51d336d96f/ui/display/BUILD.gn [delete] https://crrev.com/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d/ui/display/screen_fuchsia.cc
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/deps/icu.git/+/08cb956852a5ccdba7f9c941728bb833529ba3c6 commit 08cb956852a5ccdba7f9c941728bb833529ba3c6 Author: Scott Graham <scottmg@chromium.org> Date: Mon Aug 14 19:22:33 2017 fuchsia: Rename icuuc and icui18n for component mode Because the Fuchsia system bootdata.bin puts libicuuc.so and libicui18n.so in /system/lib already (and they don't match our build), and we have same-named .sos in component build, rename our copy. Bug: 732897, 743296 Change-Id: Ia195230c14d515ed14f9d90eb35aa87301eab601 Reviewed-on: https://chromium-review.googlesource.com/613506 Reviewed-by: Nico Weber <thakis@chromium.org> [modify] https://crrev.com/08cb956852a5ccdba7f9c941728bb833529ba3c6/BUILD.gn
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6864ab5f4e21dabb6bcffaafff76bc869c13b2d commit b6864ab5f4e21dabb6bcffaafff76bc869c13b2d Author: Jungshik Shin <jshin@chromium.org> Date: Tue Aug 15 19:23:00 2017 Roll ICU to 08cb956 and update the layout tests There are two CLs in the roll: https://chromium.googlesource.com/chromium/deps/icu/+log/98218d1..08cb956 08cb956 fuchsia: Rename icuuc and icui18n for component mode af9ff77 Update a few items in the data UTF-32 is not listed in the encoding list any more in Chrome's copy of ICU so that there's no more need to filter it out. A few encoding name aliases for GBK/GB18030 are also dropped in Chrome's copy of ICU to match the WHATWG encoding spec and to pass fast/encoding/supported-encodings.html. BUG=544228,339862,732897, 743296 , v8:6031 TEST=LayoutTests: fast/encoding/supported-encodings.html Change-Id: Iba169ee7a40d3121bb687be1d62e3058a9998411 Reviewed-on: https://chromium-review.googlesource.com/612785 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#494490} [modify] https://crrev.com/b6864ab5f4e21dabb6bcffaafff76bc869c13b2d/DEPS [modify] https://crrev.com/b6864ab5f4e21dabb6bcffaafff76bc869c13b2d/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [delete] https://crrev.com/39e3e5d18e666ae2f3d0a384ffc12ab273d29b68/third_party/WebKit/LayoutTests/fast/encoding/GBK/EUC-CN-expected.txt [delete] https://crrev.com/39e3e5d18e666ae2f3d0a384ffc12ab273d29b68/third_party/WebKit/LayoutTests/fast/encoding/GBK/EUC-CN.html [modify] https://crrev.com/b6864ab5f4e21dabb6bcffaafff76bc869c13b2d/third_party/WebKit/LayoutTests/fast/encoding/char-decoding.html [modify] https://crrev.com/b6864ab5f4e21dabb6bcffaafff76bc869c13b2d/third_party/WebKit/LayoutTests/fast/encoding/char-encoding.html [modify] https://crrev.com/b6864ab5f4e21dabb6bcffaafff76bc869c13b2d/third_party/WebKit/LayoutTests/fast/encoding/supported-encodings-expected.txt [modify] https://crrev.com/b6864ab5f4e21dabb6bcffaafff76bc869c13b2d/third_party/WebKit/Source/platform/wtf/text/TextCodecICU.cpp
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42c92f894d4fa7c0ee8633f42d5e9bafad93e885 commit 42c92f894d4fa7c0ee8633f42d5e9bafad93e885 Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 18 19:45:58 2017 fuchsia: Stub SelectFileDialog Needed for headless_shell in is_component_mode=true. Bug: 743296 , 746674 Change-Id: Idcec3a837dab82557876bc49d33e47a3b9405e8b Reviewed-on: https://chromium-review.googlesource.com/621396 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#495651} [modify] https://crrev.com/42c92f894d4fa7c0ee8633f42d5e9bafad93e885/ui/shell_dialogs/BUILD.gn [add] https://crrev.com/42c92f894d4fa7c0ee8633f42d5e9bafad93e885/ui/shell_dialogs/select_file_dialog_fuchsia.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ec652a0aa0cd5e0bad5110a5491888478c00bc3 commit 5ec652a0aa0cd5e0bad5110a5491888478c00bc3 Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 18 20:08:14 2017 fuchsia: Add missing stub method on ChildProcessLauncherHelper Needed for headless_shell in is_component_mode=true. Bug: 743296 , 746674 Change-Id: Ie121968e2a23058a6da1fb1dabcd3bce21d163a2 Reviewed-on: https://chromium-review.googlesource.com/621397 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#495662} [modify] https://crrev.com/5ec652a0aa0cd5e0bad5110a5491888478c00bc3/content/browser/child_process_launcher_helper_fuchsia.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5459cc3e30f0a2d79046d76ae60f309b6494061b commit 5459cc3e30f0a2d79046d76ae60f309b6494061b Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 18 20:16:30 2017 fuchsia: Add implementation of GetFontList_SlowBlocking() Needed for headless_shell in is_component_mode=true. Bug: 743296 , 746674 Change-Id: I8a7bf90a8b0456b0efddf5f1e4f37ee60db5d97b Reviewed-on: https://chromium-review.googlesource.com/621399 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#495663} [modify] https://crrev.com/5459cc3e30f0a2d79046d76ae60f309b6494061b/content/common/BUILD.gn [add] https://crrev.com/5459cc3e30f0a2d79046d76ae60f309b6494061b/content/common/font_list_fuchsia.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61ea11ee9494e1863fbf88819dceef85397e5ac5 commit 61ea11ee9494e1863fbf88819dceef85397e5ac5 Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 18 20:22:15 2017 fuchsia: Stub process_metrics' GetSystemMemoryInfo Needed for headless_shell in is_component_mode=true. Bug: 706592, 743296 , 746674 Change-Id: Ic2fba5cad27a171542c36fb1ccae0168a93089e5 Reviewed-on: https://chromium-review.googlesource.com/621422 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#495665} [modify] https://crrev.com/61ea11ee9494e1863fbf88819dceef85397e5ac5/base/process/process_metrics.h [modify] https://crrev.com/61ea11ee9494e1863fbf88819dceef85397e5ac5/base/process/process_metrics_fuchsia.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9c09d0ef9d990fe508d581364b9c5f1a22a0e3a commit f9c09d0ef9d990fe508d581364b9c5f1a22a0e3a Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 18 20:30:12 2017 fuchsia: Add no-op implementation of HasSeekPenalty Needed for headless_shell in is_component_mode=true. Bug: 743296 , 746674 Change-Id: I538cddef2db42b82527a0d3cb13fe77f48710e35 Reviewed-on: https://chromium-review.googlesource.com/621766 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#495669} [modify] https://crrev.com/f9c09d0ef9d990fe508d581364b9c5f1a22a0e3a/components/metrics/BUILD.gn [add] https://crrev.com/f9c09d0ef9d990fe508d581364b9c5f1a22a0e3a/components/metrics/drive_metrics_provider_fuchsia.cc
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dab3f12cdb2a2116d1cad33f571182f013e36609 commit dab3f12cdb2a2116d1cad33f571182f013e36609 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 23 18:06:23 2017 fuchsia: Add missing headless dependencies for is_component_mode Needed for headless_shell in is_component_mode=true. Bug: 743296 , 746674 Change-Id: I18f7e7338a1a08edfaa773a59f54a86ace4b6df1 Reviewed-on: https://chromium-review.googlesource.com/621768 Reviewed-by: Eric Seckler <eseckler@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496737} [modify] https://crrev.com/dab3f12cdb2a2116d1cad33f571182f013e36609/headless/BUILD.gn
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf0983132001f40c403ccfda04128d3a012bee20 commit cf0983132001f40c403ccfda04128d3a012bee20 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 23 19:40:48 2017 fuchsia: update SelectFileDialog after unique_ptr change Signature changed at https://chromium-review.googlesource.com/c/chromium/src/+/619613, but there's only a fuchsia release, no fuchsia (dbg) on the CQ/waterfall yet, and it happens to link in release without this. Bug: 743296 , 746674 Change-Id: Ifeb7663a9338b9e424ebb39fac6408989ca0b43c Reviewed-on: https://chromium-review.googlesource.com/629199 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496769} [modify] https://crrev.com/cf0983132001f40c403ccfda04128d3a012bee20/ui/shell_dialogs/select_file_dialog_fuchsia.cc
,
Nov 29 2017
,
Dec 8 2017
Gatekeeper was enabled for the Debug FYI bot in https://chromium-review.googlesource.com/c/chromium/tools/build/+/815996, and the bot itself (usually) compiles, so closing this out. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by w...@chromium.org
, Jul 15 2017