New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 743275 link

Starred by 1 user
Status: Fixed
Owner:
█ nyquist@chromium.org
Traveling - Back 2/6
Closed: Jul 2017
Cc:
█ catherinechung@google.com
█ nyquist@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 750269



Sign in to add a comment

Renaming the namespace feature_engagement_tracker

Project Member Reported by catherinechung@google.com, Jul 14 2017 
The component FeatureEngagementTracker (//components/feature_engagement_tracker) lives in the namespace feature_engagement_tracker.

It was suggested to rename all directories and namespace to feature_engagement instead and remove "FeatureEngagement" from all class names.

ie. feature_engagement::Tracker or feature_engagement::TrackerFactory

Comment 1 by catherinechung@google.com, Jul 14 2017

Description: Show this description
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 17 2017

Labels: Hotlist-Google

Comment 3 by nyquist@chromium.org, Jul 17 2017 

Let's go ahead and do this.

- Rename namespace feature_engagement_tracker to feature_engagement
- Rename //chrome/browser/feature_engagement_tracker to //chrome/browser/feature_engagement
- Rename //components/feature_engagement_tracker to //components/feature_engagement
- Remove FeatureEngagement-prefix from all class-names, i.e. FeatureEngagementTracker -> Tracker

Feel free to reassign to me if you want.

Comment 4 by nyquist@chromium.org, Jul 17 2017 

We should also rename the chromium component to be Internals>FeatureEngagement.

Also, the README.md in the component must be updated.

Comment 5 by catherinechung@google.com, Jul 18 2017 

Ok, would you mind doing this refactoring after my code has landed?

Comment 6 by nyquist@chromium.org, Jul 18 2017

Cc: catherinechung@google.com
Labels: M-61
Owner: nyquist@chromium.org
Status: Assigned (was: Untriaged)
Sure, we can wait until that lands.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1d6dea1765f89ba4063ed82231014e106698054

commit c1d6dea1765f89ba4063ed82231014e106698054
Author: Tommy Nyquist <nyquist@chromium.org>
Date: Wed Jul 26 20:37:23 2017

Rename feature_engagement_tracker component to feature_engagement

This CL renames the following things:
- //components/feature_engagement_tracker
  -> //component/feature_engagement
- namespace feature_engagement_tracker -> feature_engagement
- FeatureEngagementTracker -> Tracker
- FeatureEngagementTrackerFactory -> TrackerFactory

And updates the related test, factories, etc.

This CL also removes the now unnecessary JNI registry setup.

BUG= 743275 

Change-Id: Ibc9a31c33f3139bfccbfb20487f1e4438409fd80
Reviewed-on: https://chromium-review.googlesource.com/581911
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489743}
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/DEPS
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/src/org/chromium/chrome/browser/feature_engagement/OWNERS
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/src/org/chromium/chrome/browser/feature_engagement/ScreenshotMonitor.java
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/src/org/chromium/chrome/browser/feature_engagement/ScreenshotMonitorDelegate.java
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/src/org/chromium/chrome/browser/feature_engagement/TrackerFactory.java
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/chrome/android/java/src/org/chromium/chrome/browser/feature_engagement_tracker/FeatureEngagementTrackerFactory.java
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/chrome/android/java/src/org/chromium/chrome/browser/feature_engagement_tracker/OWNERS
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionMainMenuFooter.java
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/java_sources.gni
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/android/javatests/src/org/chromium/chrome/browser/feature_engagement/ScreenshotMonitorTest.java
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/about_flags.cc
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/android/feature_engagement/OWNERS
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/android/feature_engagement/tracker_factory_android.cc
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/chrome/browser/android/feature_engagement_tracker/OWNERS
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/chrome/browser/android/feature_engagement_tracker/feature_engagement_tracker_factory_android.cc
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/feature_engagement/DEPS
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/feature_engagement/OWNERS
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/feature_engagement/new_tab/new_tab_tracker.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/feature_engagement/new_tab/new_tab_tracker.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/feature_engagement/new_tab/new_tab_tracker_factory.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/feature_engagement/new_tab/new_tab_tracker_factory.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/feature_engagement/new_tab/new_tab_tracker_unittest.cc
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/feature_engagement/tracker_factory.cc
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/feature_engagement/tracker_factory.h
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/chrome/browser/feature_engagement_tracker/DEPS
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/chrome/browser/feature_engagement_tracker/OWNERS
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/chrome/browser/feature_engagement_tracker/feature_engagement_tracker_factory.cc
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/chrome/browser/feature_engagement_tracker/feature_engagement_tracker_factory.h
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/chrome/test/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/BUILD.gn
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/BUILD.gn
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/DEPS
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/OWNERS
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/README.md
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/components_unittests.filter
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/BUILD.gn
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/android/java/src/org/chromium/components/feature_engagement/internal/TrackerImpl.java
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/android/tracker_impl_android.cc
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/android/tracker_impl_android.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/availability_model.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/availability_model_impl.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/availability_model_impl.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/availability_model_impl_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/chrome_variations_configuration.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/chrome_variations_configuration.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/chrome_variations_configuration_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/condition_validator.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/condition_validator.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/condition_validator_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/configuration.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/configuration.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/configuration_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/editable_configuration.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/editable_configuration.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/editable_configuration_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/event_model.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/event_model_impl.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/event_model_impl.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/event_model_impl_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/event_storage_validator.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/event_store.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/feature_config_condition_validator.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/feature_config_condition_validator.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/feature_config_condition_validator_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/feature_config_event_storage_validator.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/feature_config_event_storage_validator.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/feature_config_event_storage_validator_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/in_memory_event_store.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/in_memory_event_store.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/in_memory_event_store_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/init_aware_event_model.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/init_aware_event_model.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/init_aware_event_model_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/never_availability_model.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/never_availability_model.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/never_availability_model_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/never_condition_validator.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/never_condition_validator.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/never_condition_validator_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/never_event_storage_validator.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/never_event_storage_validator.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/never_event_storage_validator_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/once_condition_validator.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/once_condition_validator.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/once_condition_validator_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/persistent_availability_store.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/persistent_availability_store.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/persistent_availability_store_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/persistent_event_store.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/persistent_event_store.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/persistent_event_store_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/proto/BUILD.gn
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/proto/availability.proto
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/proto/event.proto
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/single_invalid_configuration.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/single_invalid_configuration.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/single_invalid_configuration_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/stats.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/stats.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/system_time_provider.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/system_time_provider.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/system_time_provider_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/test/BUILD.gn
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/test/event_util.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/test/event_util.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/time_provider.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/tracker_impl.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/tracker_impl.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/internal/tracker_impl_unittest.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/public/BUILD.gn
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/Tracker.java
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/public/event_constants.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/public/event_constants.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/public/feature_constants.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/public/feature_constants.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/public/feature_list.cc
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/public/feature_list.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/public/tracker.h
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/test/BUILD.gn
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/test/test_tracker.cc
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/components/feature_engagement/test/test_tracker.h
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/components/feature_engagement_tracker/BUILD.gn
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.cc
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.h
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/components/feature_engagement_tracker/internal/android/feature_engagement_tracker_jni_registrar.cc
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/components/feature_engagement_tracker/internal/android/java/src/org/chromium/components/feature_engagement_tracker/internal/FeatureEngagementTrackerImpl.java
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/components/feature_engagement_tracker/public/android/feature_engagement_tracker_jni_registrar.h
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/components/feature_engagement_tracker/test/BUILD.gn
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/components/feature_engagement_tracker/test/test_feature_engagement_tracker.cc
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/components/feature_engagement_tracker/test/test_feature_engagement_tracker.h
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/app/DEPS
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/app/application_delegate/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/app/application_delegate/app_state.mm
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/DEPS
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/browser_state/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/feature_engagement/BUILD.gn
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/feature_engagement/OWNERS
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/feature_engagement/tracker_factory.h
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/feature_engagement/tracker_factory.mm
[rename] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/feature_engagement/tracker_util.h
[add] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/feature_engagement/tracker_util.mm
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/ios/chrome/browser/feature_engagement_tracker/feature_engagement_tracker_factory.h
[delete] https://crrev.com/5370625336fdfa7630d6399a97234ca3ba9bfcc3/ios/chrome/browser/feature_engagement_tracker/feature_engagement_tracker_util.mm
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm
[modify] https://crrev.com/c1d6dea1765f89ba4063ed82231014e106698054/tools/android/eclipse/.classpath

Comment 8 by nyquist@chromium.org, Jul 26 2017

Status: Fixed (was: Assigned)

Comment 9 by nyquist@chromium.org, Jul 28 2017

Blocking: 750269
►

Sign in to add a comment