In https://crbug.com/742039 I caused a DCHECK to fail ("Check failed: property_trees()->needs_rebuild.") but the stacktrace in the standard out on the bot is not symbolized. https://luci-milo.appspot.com/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/219538 stdout: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.android%2Fandroid_n5x_swarming_rel%2F219538%2F%2B%2Frecipes%2Fsteps%2Ftelemetry_perf_unittests__with_patch__on_Android%2F0%2Fstdout When I run this test locally I am able to get a symbolized stacktrace.
hzl -- this looks like it may be another place where we need to get the appropriate unstripped lib into the isolate.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55fc2af69da5f96e351e5aea26cfe75b95cf1887 commit 55fc2af69da5f96e351e5aea26cfe75b95cf1887 Author: hzl <hzl@google.com> Date: Thu Jul 27 08:24:50 2017 Fix the stack script issue when symbolizing tombstones. Include the *.so files in lib.unstripped and the *.so files that are in apks so that we have the right symbols when symbolizing tombstones. BUG= 743268 Review-Url: https://codereview.chromium.org/2974163002 Cr-Commit-Position: refs/heads/master@{#489882} [modify] https://crrev.com/55fc2af69da5f96e351e5aea26cfe75b95cf1887/build/android/gyp/create_test_runner_script.py [modify] https://crrev.com/55fc2af69da5f96e351e5aea26cfe75b95cf1887/build/android/gyp/write_build_config.py [modify] https://crrev.com/55fc2af69da5f96e351e5aea26cfe75b95cf1887/build/android/pylib/instrumentation/instrumentation_test_instance.py [modify] https://crrev.com/55fc2af69da5f96e351e5aea26cfe75b95cf1887/build/android/pylib/local/device/local_device_instrumentation_test_run.py [add] https://crrev.com/55fc2af69da5f96e351e5aea26cfe75b95cf1887/build/android/pylib/symbols/stack_symbolizer.py [modify] https://crrev.com/55fc2af69da5f96e351e5aea26cfe75b95cf1887/build/android/test_runner.py [modify] https://crrev.com/55fc2af69da5f96e351e5aea26cfe75b95cf1887/build/android/test_runner.pydeps [modify] https://crrev.com/55fc2af69da5f96e351e5aea26cfe75b95cf1887/build/android/tombstones.py [modify] https://crrev.com/55fc2af69da5f96e351e5aea26cfe75b95cf1887/build/config/android/internal_rules.gni [modify] https://crrev.com/55fc2af69da5f96e351e5aea26cfe75b95cf1887/build/config/android/rules.gni [modify] https://crrev.com/55fc2af69da5f96e351e5aea26cfe75b95cf1887/tools/mb/mb.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70b5e50528fbc7820a40bf35508c6535de7e9e5f commit 70b5e50528fbc7820a40bf35508c6535de7e9e5f Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Tue Aug 22 00:59:08 2017 Roll src/third_party/catapult/ 333dc8e65..837e443f6 (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/333dc8e655b2..837e443f6dcf $ git log 333dc8e65..837e443f6 --date=short --no-merges --format='%ad %ae %s' 2017-08-21 hzl Make varaible THREADTIME_RE_FORMAT public. Created with: roll-dep src/third_party/catapult BUG= 743268 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7472a7da8fa0fc4c77da49f7aa7a9cb920958790 Reviewed-on: https://chromium-review.googlesource.com/624531 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#496142} [modify] https://crrev.com/70b5e50528fbc7820a40bf35508c6535de7e9e5f/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e9529dbdf0d361828dd2ead10018f79dff36fba commit 4e9529dbdf0d361828dd2ead10018f79dff36fba Author: Zhiling Huang <hzl@chromium.org> Date: Fri Sep 01 21:55:24 2017 Symbolize the stdout of gtests. Previously if a gtest crashes, unsymbolized stack will show up in stdout. In this cl, I symbolized the stdout so that people can easily debug the crash. Bug: 743268 Change-Id: I0d5c71962cf417c2d0cbcef1042a41d820a89c7a Reviewed-on: https://chromium-review.googlesource.com/633808 Commit-Queue: Zhiling Huang <hzl@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#499320} [modify] https://crrev.com/4e9529dbdf0d361828dd2ead10018f79dff36fba/build/android/pylib/gtest/gtest_test_instance.py [modify] https://crrev.com/4e9529dbdf0d361828dd2ead10018f79dff36fba/build/android/pylib/gtest/gtest_test_instance_test.py [modify] https://crrev.com/4e9529dbdf0d361828dd2ead10018f79dff36fba/build/android/pylib/local/device/local_device_gtest_run.py [modify] https://crrev.com/4e9529dbdf0d361828dd2ead10018f79dff36fba/build/config/android/rules.gni
Moving Infra>Client>Android -> Infra>Client>Chrome+OS=Android
Comment 1 by jbudorick@chromium.org
, Jul 14 2017Status: Assigned (was: Untriaged)