New issue
Advanced search Search tips

Issue 743265 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 749198

Blocking:
issue 368963
issue 684311



Sign in to add a comment

drop obsolete autotest features (run client test in background, run client test with --continue

Project Member Reported by pprabhu@chromium.org, Jul 14 2017

Issue description

(1) server/autotest.py can run a client test in background.
This feature is dangerous (because it leaves the client test running on the DUT outside autoserv's control) and only used by one test (power_USBUnplugInSuspend) that hasn't run in a while.

(2) A client test also has the notion of "steps", which allows the test to be continued past a reboot. There is server side support to --continue such a test. This feature is unused. The preferred way to get this functionality is to write a server-side test.

Both these features are untested, possibly broken, (somewhat) dangerous and are making improving parsing of the results hard (because of arbitrary result nesting from the client side).

So, I'm dropping them. In the process, I'm breaking the one test that uses the background feature. Both these features have already been discussed on the relevant mailing lists, so it shouldn't surprise anybody when they disapear.
 
Blocking: 684311
Labels: -Pri-3 Pri-2
Also see https://bugs.chromium.org/p/chromium/issues/detail?id=684311#c9 as proof that (2) is not used anywhere.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/dfc615cce2a0ed1766edc919b3bfa627463f6067

commit dfc615cce2a0ed1766edc919b3bfa627463f6067
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Jul 18 01:32:40 2017

Add warning to a test I am about to actively break

BUG=chromium:743265
TEST=None

Change-Id: I1bbd5ec3e19341b17af69ad36c4186a157dc5d87
Reviewed-on: https://chromium-review.googlesource.com/572219
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/dfc615cce2a0ed1766edc919b3bfa627463f6067/server/site_tests/power_USBHotplugInSuspend/power_USBHotplugInSuspend.py
[modify] https://crrev.com/dfc615cce2a0ed1766edc919b3bfa627463f6067/server/site_tests/power_USBHotplugInSuspend/control

Blockedon: 749198
CLs in #4 are being reverted because of  issue 749198 
Hi, this bug has not been updated recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be archived. Thank you.
Owner: ----
Status: Untriaged (was: Started)
Back to untriaged --> I'm not working on this anymore and the roadblocks I hit are too painful to remove for the low returns on this effort.
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)
Blocking: 368963

Sign in to add a comment