New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 743257 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 671355



Sign in to add a comment

Linux ChromiumOS Builders on the chromium.gpu.fyi waterfall is still building with X11

Project Member Reported by dpranke@chromium.org, Jul 14 2017

Issue description

We've flipped nearly all of the ChromiumOS builders over the use Ozone by default, but it looks like the "Linux ChromiumOS Builder" on the chromium.gpu.fyi waterfall builds "All" and in this particular config the compile fails.

I'm flipping the builder back to X11, but we need to get it onto Ozone instead.

Also, the "Linux ChromiumOS Ozone Builder" on the same waterfall is, confusingly, building Linux Desktop + Ozone, not Linux Desktop ChromeOS + Ozone (see  bug 743212 ). Once we fix that,
one of these two builders is probably redundant.
 
Cc: geoffl...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8729af596e1da9ce678ba5d037dd467d54aa1999

commit 8729af596e1da9ce678ba5d037dd467d54aa1999
Author: Dirk Pranke <dpranke@chromium.org>
Date: Fri Jul 14 23:10:24 2017

Attempt to fix chromium.gpu.fyi/Linux ChromiumOS Builder.

My change in #486768 flipped this builder from ChomeOS/X11 to
ChromeOS/Ozone, but it looks like that config may not successfully
build 'All' correctly. This change reverts the config for that
particular builder (so that we keep building X11 for now), but
we need to fix the build so that it is using Ozone instead.

TBR=kbr@chromium.org, jmadill@chromium.org, kylechar@chromium.org, fhenigman@chromium.org
NOTRY=true
BUG= 671355 ,  743257 

Change-Id: Ic4739ef28a35fa556c662ba19221530217f0556f
Reviewed-on: https://chromium-review.googlesource.com/572384
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486917}
[modify] https://crrev.com/8729af596e1da9ce678ba5d037dd467d54aa1999/tools/mb/mb_config.pyl

Blocking: 671355
Cc: -kylec...@chromium.org fjhenigman@chromium.org
Owner: kylec...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/707b902647ddfb40c6d052a49af7d4ab7e0c52b5

commit 707b902647ddfb40c6d052a49af7d4ab7e0c52b5
Author: kylechar <kylechar@chromium.org>
Date: Fri Jul 28 18:15:10 2017

Switch Linux ChromiumOS Builder from X11 to Ozone.

This trybot configuration compiles with use_ozone=true, so remove the
additional use_ozone=false in mb_config.pyl.

I *think* this kills the last trybot building X11 CrOS.

Bug:  743257 
Change-Id: I11c742b505bce4ae07da45894e72a481aef73799
Reviewed-on: https://chromium-review.googlesource.com/591614
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490467}
[modify] https://crrev.com/707b902647ddfb40c6d052a49af7d4ab7e0c52b5/tools/mb/mb_config.pyl

Status: Fixed (was: Started)
Linux ChromiumOS Builder picked up the change and it compiled:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20ChromiumOS%20Builder/builds/32976

Comment 7 by kbr@chromium.org, Jul 28 2017

Thanks kylechar@ for picking this up!

Sign in to add a comment