New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 743239 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Consider using layer animations for simple gesture nav UI

Project Member Reported by moh...@chromium.org, Jul 14 2017

Issue description

Currently SimpleGestureNav uses a single layer and paints everything on that layer according to the current drag/animation state. We can use multiple layers and layer animations instead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb306d2641b7dc302adf0203d37cc81be2ed838a

commit fb306d2641b7dc302adf0203d37cc81be2ed838a
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Wed Aug 02 04:05:41 2017

Move gesture nav arrow to its own layer

Currently, gesture nav affordance uses a single layer that paints
everything in each frame. This CL moves the arrow to its own layer which
is drawn once and then appropriate transform and opacity are applied on
it. This is needed for implementing pull-to-refresh which needs the
arrow be rotated. Also, generally we want to decompose the affordance
into a few layers to avoid painting it on each frame.

BUG= 702404 ,743239
TEST=none

Change-Id: I9140471d6b6edbbb84f97fd5148994fea58e5a90
Reviewed-on: https://chromium-review.googlesource.com/594840
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491261}
[modify] https://crrev.com/fb306d2641b7dc302adf0203d37cc81be2ed838a/content/browser/web_contents/aura/gesture_nav_simple.cc
[modify] https://crrev.com/fb306d2641b7dc302adf0203d37cc81be2ed838a/content/browser/web_contents/aura/gesture_nav_simple.h

Comment 2 by varkha@chromium.org, Sep 20 2017

Labels: -Pri-2 Pri-3
Cc: -mfomitchev@chromium.org

Sign in to add a comment