Cronet HTTP_CACHE_DISK_NO_HTTP behavior is strange and not documented |
|||
Issue descriptionCopying from issue 740207 : Why does HTTP_CACHE_IN_MEMORY enable DNS cache but HTTP_CACHE_DISK_NO_HTTP doesn't? What is HTTP_CACHE_DISK_NO_HTTP even for? I read our documentation and it doesn't really say. Unfortunately this involves behavior way deep in the net stack and might be tricky to change.
,
Jul 17 2017
> I should mention that the DNS cache generally doesn't provide much benefit on Android. For more verbose explanation see crbug.com/621958#c3 , things may have changed since the stale cache work.
,
Jul 17 2017
Thanks for pointing to that bug, I missed it. They're not quite the same bug but they have the same underlying cause. It's becoming more of an issue now with the stale DNS work.
,
Nov 30 2017
,
Mar 23 2018
I fixed the "strange" part in https://crrev.com/c/976539. Not sure why it didn't update here.
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a01b16799fefbbc30092cc6d79a0bb77db4221f commit 2a01b16799fefbbc30092cc6d79a0bb77db4221f Author: Miriam Gershenson <mgersh@chromium.org> Date: Thu Mar 22 22:54:47 2018 Reduce load flags that affect the host cache Previously, all three of the load flags that prevent use of the HTTP cache also prevented use of the DNS cache when using the socket pools. This is not the desired behavior for most consumers of those load flags. LOAD_BYPASS_CACHE has some consumers that might be depending on the behavior, so it stays the same. LOAD_DISABLE_CACHE and LOAD_VALIDATE_CACHE will not affect the host cache. Details: https://docs.google.com/document/d/1CuGd8ZnGd56L0wpX1jkB96Lm6IF9fF409h234AqjtNw/edit?usp=sharing Bug: 743235 , 621958 Change-Id: I4560cc3bf96da2f19c10a5c68179d9294012f549 Reviewed-on: https://chromium-review.googlesource.com/976539 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#545279} [modify] https://crrev.com/2a01b16799fefbbc30092cc6d79a0bb77db4221f/net/base/load_flags_list.h [modify] https://crrev.com/2a01b16799fefbbc30092cc6d79a0bb77db4221f/net/http/http_network_transaction_unittest.cc [modify] https://crrev.com/2a01b16799fefbbc30092cc6d79a0bb77db4221f/net/socket/client_socket_pool_manager.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by pauljensen@chromium.org
, Jul 17 2017