Remove Linux ChromiumOS Ozone Builder |
||||||||||||||||
Issue description
In src/tools/mb/mb_config.pyl, Linux ChromiumOS Ozone Builder was using the configuration gpu_fyi_tests_chromeos_ozone_release_trybot which was defined as follows:
'gpu_fyi_tests_chromeos_ozone_release_trybot': [
'gpu_fyi_tests', 'release_trybot', 'ozone', 'ozone_linux', 'system_gbm_libdrm',
],
In other words, desktop Linux, not ChromeOS flavor.
In https://chromium-review.googlesource.com/572301/ this was just changed and fixed to not claim it's ChromeOS. I think it was supposed to be building that flavor, so filing a follow-up bug.
,
Jul 18 2017
,
Jul 28 2017
,
Aug 21 2017
I believe that 'Linux ChromiumOS Ozone' is actually redundant with 'Linux ChromiumOS' now? The args.gn generated in the logs are identical. There is one important difference though: 'Linux ChromiumOS Ozone' runs ninja with 'All all' as the target, whereas 'Linux ChromiumOS' provides a list of targets. This is new behavior, introduced here: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/54289 I suspect by this change: https://chromium-review.googlesource.com/616011 Associated with issue 750642
,
Aug 21 2017
,
Aug 21 2017
If that's true we can probably scrap the custom Ozone config. Frank any objections?
,
Aug 22 2017
Which builders are we talking about? These two? https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20ChromiumOS%20Builder I don't think I'll miss the latter if it goes away. Dirk: did we talk a while ago about you removing a redundant builder? I can't find the conversation. Was it the same one?
,
Aug 28 2017
Renaming to reflect what seems to be the consensus. What is the next step here?
,
Aug 28 2017
Issue 759625 has been merged into this issue.
,
Aug 28 2017
,
Aug 31 2017
The gpu.fyi builder is the one we talked about w/ fjhenigman@. Both of them are redundant and should just be removed. I think I had CLs in flight to do so at one point and then got distracted and forgot about them.
,
Aug 31 2017
,
Sep 1 2017
Issue 760436 has been merged into this issue.
,
Sep 1 2017
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/2c9b8f36f221ba9ea50fd50feb102850c977ab29 commit 2c9b8f36f221ba9ea50fd50feb102850c977ab29 Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Sep 01 22:59:02 2017 Remove ChromiumOS Ozone builders. This removes "Linux ChromiumOS Ozone Builder" and "Linux ChromiumOS Ozone Tests (1)" from the chromium.chromiumos waterfall; ozone is now on by default and these builders are redundant and misconfigured. R=hinoka@chromium.org BUG= 743212 Change-Id: I439f9a2aca1d2eb798d270e1fe0e4f1c51114a4a Reviewed-on: https://chromium-review.googlesource.com/648453 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/2c9b8f36f221ba9ea50fd50feb102850c977ab29/masters/master.chromium.chromiumos/builders.pyl [modify] https://crrev.com/2c9b8f36f221ba9ea50fd50feb102850c977ab29/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py
,
Sep 1 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/ec3b4075971e99d0d04267ac2b7e3f4483a0305f commit ec3b4075971e99d0d04267ac2b7e3f4483a0305f Author: Dirk Pranke <dpranke@google.com> Date: Fri Sep 01 23:05:58 2017
,
Sep 1 2017
The chromium.chromiumos builder is now gone. Per conversation w/ fjhenigman in https://chromium-review.googlesource.com/c/chromium/tools/build/+/648358 we'll rename the gpu.fyi bot to not have "ChromiumOS" in the name.
,
Sep 2 2017
,
Sep 2 2017
Dirk I think your change broke the ANGLE CQ: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/430118 Traceback (most recent call last): File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/run.py", line 328, in _new_run recipe_result = recipe_script.run(api, properties) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 98, in run self.run_steps, properties, self.PROPERTIES, api=api) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 627, in invoke_with_properties **additional_args) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 588, in _invoke_with_properties return callable_obj(*props, **additional_args) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/recipes/chromium_trybot.py", line 45, in RunSteps return api.chromium_tests.trybot_steps() File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 745, in _inner return func(*a, **kw) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/recipe_modules/chromium_tests/api.py", line 886, in trybot_steps disable_deapply_patch) = self._trybot_steps_internal() File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 745, in _inner return func(*a, **kw) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/recipe_modules/chromium_tests/api.py", line 912, in _trybot_steps_internal bot_update_step, bot_db = self.prepare_checkout(bot_config_object) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 745, in _inner return func(*a, **kw) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/recipe_modules/chromium_tests/api.py", line 225, in prepare_checkout bot_config, root_solution_revision, disable_syntax_validation) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 745, in _inner return func(*a, **kw) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/recipe_modules/chromium_checkout/api.py", line 78, in ensure_checkout disable_syntax_validation=disable_syntax_validation) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 745, in _inner return func(*a, **kw) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/api.py", line 112, in ensure_checkout self.m.properties.get('patch_project'), cfg) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 745, in _inner return func(*a, **kw) File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/gclient/api.py", line 334, in calculate_patch_root return cfg.solutions[0].name File "/b/rr/tmppSbNZi/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/config.py", line 525, in __getitem__ return self.data.__getitem__(index) IndexError: list index out of range
,
Sep 2 2017
@jmadill - ok. I posted https://chromium-review.googlesource.com/648654 to remove it from the angle CQ; if you want me to flip that to the regular linux_chromium_chromeos_rel_ng builder instead, let me know.
,
Sep 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/b5c5fb1b9ffbe9b9c465e50f0ef6c54451f79d49 commit b5c5fb1b9ffbe9b9c465e50f0ef6c54451f79d49 Author: Dirk Pranke <dpranke@chromium.org> Date: Sat Sep 02 22:35:09 2017 Remove linux_chromium_chromeos_ozone_rel_ng from the CQ. We're removing this bot as redundant now in Chromium. Change-Id: I35f00bff4e62780609f869c447839aa48b74b46c R: jmadill@chromium.org Bug: crbug.com/743212 Reviewed-on: https://chromium-review.googlesource.com/648654 Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/b5c5fb1b9ffbe9b9c465e50f0ef6c54451f79d49/infra/config/cq.cfg
,
Sep 5 2017
Dirk, could we add linux_chromium_chromeos_rel_ng with a custom setting to build angle_end2end_tests? I believe we did lose CQ coverage from the above removal.
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7a4196af278faad3201d9fa0ac5ade43dec0926 commit d7a4196af278faad3201d9fa0ac5ade43dec0926 Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Sep 06 02:14:38 2017 Remove ChromiumOS Ozone bots, rename gpu.fyi bot. This removes the MB entry for the now-removed ChromiumOS Ozone Builder, and renames the gpu.fyi "GPU Linux Ozone Builder" bots to be less confusing. R=kbr@chromium.org, fjhenigman@chromium.org BUG= 743212 NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2469589b985cc88018cce948de1b892b85d5053d Reviewed-on: https://chromium-review.googlesource.com/648263 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#499851} [modify] https://crrev.com/d7a4196af278faad3201d9fa0ac5ade43dec0926/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/d7a4196af278faad3201d9fa0ac5ade43dec0926/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/d7a4196af278faad3201d9fa0ac5ade43dec0926/tools/mb/mb_config.pyl
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/1c97a86e911a28513a15d33430000c0648e3d96f commit 1c97a86e911a28513a15d33430000c0648e3d96f Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Sep 06 03:24:06 2017 Remove ChromiumOS builders from the gpu.fyi waterfall. This removes the "Linux ChromiumOS Builder" from the gpu.fyi waterfall (which wasn't doing anything interesting) and renames "Linux ChromiumOS Ozone" to just "Linux Ozone" to be clearer about what it is doing. TBR=kbr@chromium.org, fjhenigman@chromium.org BUG= 743212 Change-Id: I3d5c9d3ee58fb3f5e33dc3e706aa76240c752ade Reviewed-on: https://chromium-review.googlesource.com/648358 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/1c97a86e911a28513a15d33430000c0648e3d96f/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py [modify] https://crrev.com/1c97a86e911a28513a15d33430000c0648e3d96f/masters/master.chromium.gpu.fyi/builders.pyl
,
Sep 6 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/c32228d3e16224e634159c0b7f1bbfdb326eafc1 commit c32228d3e16224e634159c0b7f1bbfdb326eafc1 Author: Dirk Pranke <dpranke@google.com> Date: Wed Sep 06 03:26:35 2017
,
Sep 6 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/ffbebfa51ff19a8c3ddf5b93662a05854dd6e56f commit ffbebfa51ff19a8c3ddf5b93662a05854dd6e56f Author: Dirk Pranke <dpranke@google.com> Date: Wed Sep 06 03:33:55 2017
,
Sep 6 2017
Marking as fixed; as for comment #22, let's talk about what, if anything, we might want to do in a new bug ( bug 762377 ).
,
Sep 6 2017
,
Sep 6 2017
,
Sep 6 2017
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae13a2f7b64ea9959e63c7871f17fe52a8327c1c commit ae13a2f7b64ea9959e63c7871f17fe52a8327c1c Author: Mike Wasserman <msw@chromium.org> Date: Mon Sep 18 21:04:16 2017 Remove deprecated linux_chromium_chromeos_ozone_rel_ng trybot. Most ChromeOS Ozone bots have been removed, this one was leftover. I noticed this when it failed to yield results for crrev.com/c/671488 Bug: 743212 Change-Id: I372b94fcfacfa920031fbfe0a7d188c40ebc8aa8 Reviewed-on: https://chromium-review.googlesource.com/671634 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#502676} [modify] https://crrev.com/ae13a2f7b64ea9959e63c7871f17fe52a8327c1c/tools/mb/mb_config.pyl
,
Jan 22 2018
,
Jan 23 2018
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by dpranke@chromium.org
, Jul 14 2017