New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 743180 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

do not show suggested apps in folder view

Project Member Reported by warx@chromium.org, Jul 14 2017

Issue description

Another bug that is related to my change. Though the folder for new launcher is not implemented yet, we definitely don't need to show suggested apps in folder view.

see the attachment:

 
Screenshot from 2017-07-14 13:44:42.png
508 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e41dab163bf7f9fdf43bbb986c4864f88e2fb6be

commit e41dab163bf7f9fdf43bbb986c4864f88e2fb6be
Author: Qiang Xu <warx@chromium.org>
Date: Fri Jul 14 23:12:17 2017

app_list: do not layout suggested apps and indicators in folder view

changes:
app_list_folder_view ctor/dtor sets/resets |folder_delegate_| in
apps_grid_view. We could use it to determine whether to layout suggested
apps and indicators or not.

TEST: tested that suggested apps/indicators doesn't show in folder view
Bug:  743180 
Change-Id: I22cdbd573dca877af726f25f53531fac1c4f40c2
Reviewed-on: https://chromium-review.googlesource.com/572364
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486921}
[modify] https://crrev.com/e41dab163bf7f9fdf43bbb986c4864f88e2fb6be/ui/app_list/views/apps_grid_view.cc

Comment 2 by warx@chromium.org, Jul 14 2017

Status: Fixed (was: Assigned)

Comment 3 by warx@chromium.org, Aug 1 2017

Labels: M-61
Status: Assigned (was: Fixed)
it is broken now, please see the attachment
Screenshot from 2017-08-01 15:12:00.png
493 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e784aa5fce4cfcaba5900c90676c9c807154c36f

commit e784aa5fce4cfcaba5900c90676c9c807154c36f
Author: Qiang Xu <warx@chromium.org>
Date: Fri Aug 04 01:09:31 2017

app_list: update opacity per suggestions container

changes:
Regression comes from https://chromium-review.googlesource.com/c/585398
where each SearchResultTileItemView is paint to layer, so that its
opacity can be controlled. In folder view, we don't layout suggestions
container view. Thus, it is better to make suggestions container view
paint to layer.

Test: test that bug is fixed
Bug:  743180 
Change-Id: Idb6151e1d58ed7265741ac4ab2c663f0a081bded
Reviewed-on: https://chromium-review.googlesource.com/599456
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491901}
[modify] https://crrev.com/e784aa5fce4cfcaba5900c90676c9c807154c36f/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/e784aa5fce4cfcaba5900c90676c9c807154c36f/ui/app_list/views/search_result_tile_item_view.cc
[modify] https://crrev.com/e784aa5fce4cfcaba5900c90676c9c807154c36f/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/e784aa5fce4cfcaba5900c90676c9c807154c36f/ui/app_list/views/suggestions_container_view.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 7 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6f32cc406abc99bcb98e842574baa74c9675168

commit c6f32cc406abc99bcb98e842574baa74c9675168
Author: Maajid <maajid@chromium.org>
Date: Mon Aug 07 21:38:15 2017

app_list: update opacity per suggestions container

changes:
Regression comes from https://chromium-review.googlesource.com/c/585398
where each SearchResultTileItemView is paint to layer, so that its
opacity can be controlled. In folder view, we don't layout suggestions
container view. Thus, it is better to make suggestions container view
paint to layer.

TBR=warx@chromium.org

(cherry picked from commit e784aa5fce4cfcaba5900c90676c9c807154c36f)

Test: test that bug is fixed
Bug:  743180 
Change-Id: Idb6151e1d58ed7265741ac4ab2c663f0a081bded
Reviewed-on: https://chromium-review.googlesource.com/599456
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491901}
Reviewed-on: https://chromium-review.googlesource.com/604480
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#372}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/c6f32cc406abc99bcb98e842574baa74c9675168/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/c6f32cc406abc99bcb98e842574baa74c9675168/ui/app_list/views/search_result_tile_item_view.cc
[modify] https://crrev.com/c6f32cc406abc99bcb98e842574baa74c9675168/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/c6f32cc406abc99bcb98e842574baa74c9675168/ui/app_list/views/suggestions_container_view.cc

Comment 6 by warx@chromium.org, Aug 8 2017

Status: Fixed (was: Assigned)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment