do not show suggested apps in folder view |
||||||
Issue descriptionAnother bug that is related to my change. Though the folder for new launcher is not implemented yet, we definitely don't need to show suggested apps in folder view. see the attachment:
,
Jul 14 2017
,
Aug 1 2017
it is broken now, please see the attachment
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e784aa5fce4cfcaba5900c90676c9c807154c36f commit e784aa5fce4cfcaba5900c90676c9c807154c36f Author: Qiang Xu <warx@chromium.org> Date: Fri Aug 04 01:09:31 2017 app_list: update opacity per suggestions container changes: Regression comes from https://chromium-review.googlesource.com/c/585398 where each SearchResultTileItemView is paint to layer, so that its opacity can be controlled. In folder view, we don't layout suggestions container view. Thus, it is better to make suggestions container view paint to layer. Test: test that bug is fixed Bug: 743180 Change-Id: Idb6151e1d58ed7265741ac4ab2c663f0a081bded Reviewed-on: https://chromium-review.googlesource.com/599456 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491901} [modify] https://crrev.com/e784aa5fce4cfcaba5900c90676c9c807154c36f/ui/app_list/views/apps_grid_view.cc [modify] https://crrev.com/e784aa5fce4cfcaba5900c90676c9c807154c36f/ui/app_list/views/search_result_tile_item_view.cc [modify] https://crrev.com/e784aa5fce4cfcaba5900c90676c9c807154c36f/ui/app_list/views/start_page_view.cc [modify] https://crrev.com/e784aa5fce4cfcaba5900c90676c9c807154c36f/ui/app_list/views/suggestions_container_view.cc
,
Aug 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6f32cc406abc99bcb98e842574baa74c9675168 commit c6f32cc406abc99bcb98e842574baa74c9675168 Author: Maajid <maajid@chromium.org> Date: Mon Aug 07 21:38:15 2017 app_list: update opacity per suggestions container changes: Regression comes from https://chromium-review.googlesource.com/c/585398 where each SearchResultTileItemView is paint to layer, so that its opacity can be controlled. In folder view, we don't layout suggestions container view. Thus, it is better to make suggestions container view paint to layer. TBR=warx@chromium.org (cherry picked from commit e784aa5fce4cfcaba5900c90676c9c807154c36f) Test: test that bug is fixed Bug: 743180 Change-Id: Idb6151e1d58ed7265741ac4ab2c663f0a081bded Reviewed-on: https://chromium-review.googlesource.com/599456 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491901} Reviewed-on: https://chromium-review.googlesource.com/604480 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#372} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/c6f32cc406abc99bcb98e842574baa74c9675168/ui/app_list/views/apps_grid_view.cc [modify] https://crrev.com/c6f32cc406abc99bcb98e842574baa74c9675168/ui/app_list/views/search_result_tile_item_view.cc [modify] https://crrev.com/c6f32cc406abc99bcb98e842574baa74c9675168/ui/app_list/views/start_page_view.cc [modify] https://crrev.com/c6f32cc406abc99bcb98e842574baa74c9675168/ui/app_list/views/suggestions_container_view.cc
,
Aug 8 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 14 2017