New issue
Advanced search Search tips

Issue 743156 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Emma coverage has build.gn errors.

Project Member Reported by rouslan@chromium.org, Jul 14 2017

Issue description

The following gn args:

dcheck_always_on = true
is_component_build = true
is_debug = true
is_clang = true
target_os = "android"
disable_incremental_isolated_processes = true
enable_incremental_javac = true
symbol_level = 1
run_findbugs = false
incremental_apk_by_default = false
emma_coverage = true                                                                                                 
emma_filter = "org.chromium.chrome.browser.*"

Result in the following error from gn:

Generating files...
ERROR at //build/config/android/rules.gni:1837:9: Undefined identifier.
        possible_config_deps +=
        ^-------------------
See //testing/android/empty_apk/empty_apk.gni:17:3: whence it was called.
  android_apk(target_name) {
  ^-------------------------
See //third_party/catapult/devil/BUILD.gn:7:1: whence it was called.
empty_apk("empty_system_webview_apk") {
^--------------------------------------
See //BUILD.gn:292:7: which caused the file to be included.
      "//third_party/catapult/devil",
      ^-----------------------------

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa4d36eac0a12a3eda691ab2b49da3ab232001c8

commit aa4d36eac0a12a3eda691ab2b49da3ab232001c8
Author: Andrew Grieve <agrieve@chromium.org>
Date: Wed Jul 19 14:58:57 2017

Fix gn gen error when enabling java coverage

Setting:
emma_coverage = true
emma_filter = "org.chromium.chrome.browser.*"

Would result in:
ERROR at //build/config/android/rules.gni:1837:9: Undefined identifier.
        possible_config_deps +=
        ^-------------------

BUG= 743156 

Change-Id: I15cf38a8ef955a312cbb7c968fafd4efa046bfd3
Reviewed-on: https://chromium-review.googlesource.com/576476
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487865}
[modify] https://crrev.com/aa4d36eac0a12a3eda691ab2b49da3ab232001c8/build/config/android/rules.gni

Owner: agrieve@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment