New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 743149 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 707006



Sign in to add a comment

[WPT Export] Make WPT Export builder turn red if an exportable commit's patch doesn't apply cleanly

Project Member Reported by jeffcarp@chromium.org, Jul 14 2017

Issue description

Via  bug 737898 

We need better alerting around commits whose patches do not apply cleanly so they don't get lost in the ether.
 
Cc: jeffcarp@chromium.org
 Issue 738502  has been merged into this issue.
 Issue 693211  has been merged into this issue.
Cc: robertma@chromium.org raphael....@intel.com
 Issue 754616  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28e0d6913b149916871fb18483e924eff2021617

commit 28e0d6913b149916871fb18483e924eff2021617
Author: Jeff Carpenter <jeffcarp@chromium.org>
Date: Wed Aug 16 20:33:48 2017

[WPT Export] Return non-zero exit code if any patches failed

This should turn the builder red if any patches failed to apply,
making it easier to notice and triage potential issues.

Bug:  743149 
Change-Id: I1a11c0b857554f67097663004542d5f3821a149b
Reviewed-on: https://chromium-review.googlesource.com/614304
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494927}
[modify] https://crrev.com/28e0d6913b149916871fb18483e924eff2021617/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py
[modify] https://crrev.com/28e0d6913b149916871fb18483e924eff2021617/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
[modify] https://crrev.com/28e0d6913b149916871fb18483e924eff2021617/third_party/WebKit/Tools/Scripts/wpt-export

Status: Fixed (was: Started)

Sign in to add a comment