New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 743147 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 739713



Sign in to add a comment

Support nested policy protobufs in policy test server

Project Member Reported by poromov@chromium.org, Jul 14 2017

Issue description

Currently it doesn't nested message if they are not repeated. For example:

message Inner {
  repeated int array = 1;
  optional string value = 2;
}

message Middle {
  optional Inner inner = 1;
}

message Outer {
  optional Middle middle = 1;
}

While such structure is not possible for user policies, for device policies the structure could be such nested.
 
Blocking: 740217
Blocking: -740217 739713

Comment 3 by tnagel@chromium.org, Jul 17 2017

Cc: -tnagel@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e69d2fbfa306af4ed5b7ce254dd98fe3edebb5

commit 70e69d2fbfa306af4ed5b7ce254dd98fe3edebb5
Author: Daria Yakovleva <yakovleva@google.com>
Date: Mon Aug 07 13:36:14 2017

Upgrade policy_testserver.py

Now policy test server supports nested protos and enum types.
It is needed for a forthcoming policy "OffHours" 
which has nested proto type.
For example:
message Inner {
  repeated int array = 1;
  optional string value = 2;
}
message Middle {
  optional Inner inner = 1;
}
message Outer {
  optional Middle middle = 1;
}

Bug:  743147 
Change-Id: If337312868b73709d248390c60a3553ba4898e99
Reviewed-on: https://chromium-review.googlesource.com/576090
Commit-Queue: Daria Iakovleva <yakovleva@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492309}
[modify] https://crrev.com/70e69d2fbfa306af4ed5b7ce254dd98fe3edebb5/chrome/browser/policy/test/policy_testserver.py

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Status: Verified (was: Fixed)
Verified fixed. The policy works correctly (see attached screenshot with the policy example).

Chrome OS: 10323.47.0
Chrome: 65.0.3325.110
Device: Kevin
Screenshot 2018-03-05 at 9.01.20 AM.png
256 KB View Download

Sign in to add a comment