New issue
Advanced search Search tips

Issue 743126 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router UI] Pseudo sink search option not available immediately after a search fails

Project Member Reported by btolsch@chromium.org, Jul 14 2017

Issue description

Chrome Version       : 61.0.3157.0

What steps will reproduce the problem?
1. Open MR UI dialog.
2. Type an invalid hangout name in the search box (e.g. "he he").
3. After route creation fails, observe the search results.

What is the expected result?
The search results should show the option to create a hangout called "he he" again.


What happens instead of that?
"No results" is displayed until the search text is changed.
 

Comment 1 by ajha@chromium.org, Jul 17 2017

Status: Untriaged (was: Unconfirmed)
Changing the bug status to Untriaged to move this from TE unconfirmed triage bucket.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bced11df3aef9b9e281217a1646ca92364b3b47

commit 8bced11df3aef9b9e281217a1646ca92364b3b47
Author: btolsch <btolsch@chromium.org>
Date: Mon Jul 17 20:59:49 2017

[Media Router UI] Fix inconsistent filter state when search fails

When search fails, the filter list may show "No results" when it should
show the pseudo sink again.  This change addresses this by re-running
the filter after the search state has been cleared in the container.

Bug:  743126 
Change-Id: I74993ab95d36d2a614b4257b6d2a9ff48f99a7db
Reviewed-on: https://chromium-review.googlesource.com/571115
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487240}
[modify] https://crrev.com/8bced11df3aef9b9e281217a1646ca92364b3b47/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/8bced11df3aef9b9e281217a1646ca92364b3b47/chrome/test/data/webui/media_router/media_router_container_search_tests.js

Status: Fixed (was: Untriaged)

Sign in to add a comment