New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 743106 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Global-buffer-overflow in SkImageInfo::unflatten

Project Member Reported by ClusterFuzz, Jul 14 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4816249568886784

Fuzzer: sugoi_filter_fuzzer
Job Type: linux_asan_filter_fuzz_stub_32bit
Platform Id: linux

Crash Type: Global-buffer-overflow READ 4
Crash Address: 0x09a6ed44
Crash State:
  SkImageInfo::unflatten
  SkBitmap::ReadRawPixels
  SkReadBuffer::readImage
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_filter_fuzz_stub_32bit&range=486347:486361

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4816249568886784


Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 

Comment 1 by raymes@chromium.org, Jul 14 2017

Components: Internals>Skia
Owner: reed@chromium.org
Status: Assigned (was: Untriaged)
There's a skia roll in the regression range. reed@ could you please help triage? Thanks!
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 15 2017

Labels: M-61
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 15 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 15 2017

Labels: Pri-1
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/b3d1d90b2870a77bf57a08c7b17ef2a2c35e9682

commit b3d1d90b2870a77bf57a08c7b17ef2a2c35e9682
Author: Mike Reed <reed@google.com>
Date: Mon Jul 17 14:59:08 2017

runtime check for in-range colortypes

Bug:743106
Change-Id: Ia014643c6f1914cf2b9b873138a0c53a783f666f
Reviewed-on: https://skia-review.googlesource.com/23943
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>

[modify] https://crrev.com/b3d1d90b2870a77bf57a08c7b17ef2a2c35e9682/src/core/SkImageInfo.cpp

Project Member

Comment 6 by ClusterFuzz, Jul 18 2017

ClusterFuzz has detected this issue as fixed in range 487099:487129.

Detailed report: https://clusterfuzz.com/testcase?key=4816249568886784

Fuzzer: sugoi_filter_fuzzer
Job Type: linux_asan_filter_fuzz_stub_32bit
Platform Id: linux

Crash Type: Global-buffer-overflow READ 4
Crash Address: 0x09a6ed44
Crash State:
  SkImageInfo::unflatten
  SkBitmap::ReadRawPixels
  SkReadBuffer::readImage
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_filter_fuzz_stub_32bit&range=486347:486361
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_filter_fuzz_stub_32bit&range=487099:487129

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4816249568886784


See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jul 18 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4816249568886784 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 18 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 24 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment