New issue
Advanced search Search tips

Issue 743098 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 740209



Sign in to add a comment

Add a flag to Chrome that simulates a low-end Android device.

Project Member Reported by chrishtr@chromium.org, Jul 14 2017

Issue description

This will help teams debug quality and performance issues a bit better
on Desktop machines.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a628c096e56e74501291dc834a96a14483526c3d

commit a628c096e56e74501291dc834a96a14483526c3d
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Jul 26 01:18:37 2017

Make kEnableLowEndDeviceMode more accurate

The kEnableLowEndDeviceMode flag currently overrides
base::SysInfo::IsLowEndDevice, but does not impact
base::SysInfo::AmountOfPhysicalMemory. Unfortunately, a lot of the code
relies directly on memory queries to turn low-end features, meaning
that we miss out on some low-end-device features.

This change updates AmountOfPhysicalMemory to always return 512MB when
running with --enable-low-end-device.

Additionally, as many low-end device features are enabled in #ifdef
OS_ANDROID blocks, they don't trigger when enabling low-end device mode
on desktop. This change pulls out once such Android-specific tweak,
RGBA_4444 textures, so it can be tested on desktop.

Change-Id: I2865598ba7e1ba800d05aaf62ea7a6720b2ce273
Bug:  743098 
Reviewed-on: https://chromium-review.googlesource.com/572121
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489511}
[modify] https://crrev.com/a628c096e56e74501291dc834a96a14483526c3d/base/sys_info.cc
[modify] https://crrev.com/a628c096e56e74501291dc834a96a14483526c3d/base/sys_info.h
[modify] https://crrev.com/a628c096e56e74501291dc834a96a14483526c3d/base/sys_info_freebsd.cc
[modify] https://crrev.com/a628c096e56e74501291dc834a96a14483526c3d/base/sys_info_fuchsia.cc
[modify] https://crrev.com/a628c096e56e74501291dc834a96a14483526c3d/base/sys_info_ios.mm
[modify] https://crrev.com/a628c096e56e74501291dc834a96a14483526c3d/base/sys_info_linux.cc
[modify] https://crrev.com/a628c096e56e74501291dc834a96a14483526c3d/base/sys_info_mac.mm
[modify] https://crrev.com/a628c096e56e74501291dc834a96a14483526c3d/base/sys_info_openbsd.cc
[modify] https://crrev.com/a628c096e56e74501291dc834a96a14483526c3d/base/sys_info_win.cc
[modify] https://crrev.com/a628c096e56e74501291dc834a96a14483526c3d/content/renderer/gpu/render_widget_compositor.cc

Comment 2 by fsamuel@google.com, Nov 24 2017

Status: Fixed (was: Assigned)

Sign in to add a comment