FATAL:template_expressions.cc(97) Check failed: value != replacements.end() |
||||||||
Issue descriptionWhen click proxy setting button as attached picture, chromeos ui crash with following log [5115:5115:0714/103724.659833:FATAL:template_expressions.cc(97)] Check failed: value != replacements.end(). $i18n replacement key "wifiNetworkTabLabel" not found #0 0x5c93422f450c base::debug::StackTrace::StackTrace() #1 0x5c934230955e logging::LogMessage::~LogMessage() #2 0x5c93423b1c34 ui::ReplaceTemplateExpressions() #3 0x5c93423b2c45 webui::GetI18nTemplateHtml() #4 0x5c934450395a (anonymous namespace)::ProxySettingsHTMLSource::StartDataRequest() #5 0x5c9340f97b31 content::URLDataManagerBackend::CallStartRequest() #6 0x5c9340f9889f _ZN4base8internal7InvokerINS0_9BindStateIPFv13scoped_refptrIN7content17URLDataSourceImplEERKSsRKNS_8CallbackIFPNS4_11WebContentsEvELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEiEJNS0_18RetainedRefWrapperIS5_EESsSF_iEEEFvvEE3RunEPNS0_13BindStateBaseE #7 0x5c9342387faa base::debug::TaskAnnotator::RunTask() #8 0x5c934230f9de base::MessageLoop::RunTask() #9 0x5c934230fdab base::MessageLoop::DeferOrRunPendingTask() #10 0x5c9342310204 base::MessageLoop::DoWork() #11 0x5c9342311959 base::MessagePumpLibevent::Run() #12 0x5c9342332996 base::RunLoop::Run() #13 0x5c9341fd3a22 ChromeBrowserMainParts::MainMessageLoopRun() #14 0x5c9340c0b5c4 content::BrowserMainLoop::RunMainMessageLoopParts() #15 0x5c9340c0de32 content::BrowserMainRunnerImpl::Run() #16 0x5c9340c0710c content::BrowserMain() #17 0x5c9341fa8216 content::ContentMainRunnerImpl::Run() #18 0x5c9341fc9edd service_manager::Main() #19 0x5c9341fa71c1 content::ContentMain() #20 0x5c93405ea93c ChromeMain #21 0x7a126b5c2736 __libc_start_main #22 0x5c93405ea7a9 _start
,
Jul 14 2017
,
Jul 14 2017
Probably related to https://chromium-review.googlesource.com/c/563608.
,
Jul 14 2017
stevenjb@ Have we since changed to using MD settings here or is this still going to the old options? For me, when I try clicking the button in the images I go do the MD settings. If we're off of the old options here, then this may no longer be an issue.
,
Jul 14 2017
Are you supposed to be able to open webui settings before the login screen? I guess yes, for proxy config? Flagging releaseblock since it's a user reproducible crash.
,
Jul 14 2017
We do not currently support Settings UI in the login screen. The proxy settings UI shows a subset of the old options UI in a separate window. It us ugly and frankly embarrassing but functional. Maybe we broke that removing some old options UI code? Long term I plan to: a) Move all of network configuration to Settings UI b) Support network Settings in the login screen (using the exact same MD Settings UI) Until then we will need to fix this.
,
Jul 14 2017
Thanks for the info. The fix could be one of A) go back to i18n-content or B) add the i18n strings (The reason for the error is that wifiNetworkTabLabel wasn't set). I prefer (B). Can anyone cc'd on this help me with repro steps (esp. helpful to have repro steps that work on chromeos on gubuntu).
,
Jul 14 2017
,
Jul 14 2017
I haven't tried, but I suspect you can build target_os="chromeos", then create an empty user-data-dir, then run with --login-manager. This will trigger the out-of-box flow and you should be able to click the menu like in the screenshot. rm -rf /tmp/foo chrome --user-data-dir=/tmp/foo --login-manager
,
Jul 14 2017
You might want to also specify a remote debugging port as follows: --user-data-dir=`mktemp -d` --login-manager --remote-debugging-port=9999 Then you can go on localhost:9999 from a different browser instance and get to the dev tools.
,
Jul 14 2017
#9 and #10 thanks for the tips! Doing an oobe creates a repro.
,
Jul 14 2017
> Support network Settings in the login screen This seems related: issue 734826 shill should not auto-initialize new USB ethernet devices while the screen is locked https://groups.google.com/a/chromium.org/d/msg/chromium-os-discuss/UqbGh2kHaVw/zBefV9aZAAAJ
,
Jul 14 2017
,
Jul 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f60bf1912f80fd88025c435396c757164ffb4aad commit f60bf1912f80fd88025c435396c757164ffb4aad Author: Dave Schuyler <dschuyler@chromium.org> Date: Mon Jul 17 19:01:41 2017 [i18n] network strings in chromeos proxy UI This CL adds the internet_options_handler_strings to the i18n set when loading the proxy_settings_ui. Bug: 743097 Change-Id: Ic5930f90d185a4f09545380de9f5af623aad626a Reviewed-on: https://chromium-review.googlesource.com/572265 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#487182} [modify] https://crrev.com/f60bf1912f80fd88025c435396c757164ffb4aad/chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc
,
Jul 17 2017
,
Jul 19 2017
Issue 745612 has been merged into this issue.
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dongseon...@intel.com
, Jul 14 20175.4 MB
5.4 MB View Download