New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 743095 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add Support for Credit Card Autofill on the Touch Bar

Project Member Reported by spqc...@chromium.org, Jul 14 2017

Issue description

Add credit card autofill support on the touch bar
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d24dbd55ffb4246c4dbd120e0954acc4d747a30c

commit d24dbd55ffb4246c4dbd120e0954acc4d747a30c
Author: spqchan <spqchan@chromium.org>
Date: Fri Jul 21 00:57:06 2017

[Mac] Add Touch Bar Support for Credit Card Autofill

Display credit card items on the touch bar when the
credit card autofill popup appears on the screen.

This feature is behind the #credit-card-autofill-touchbar
flag, which is added in this CL.

Tests: autofill_popup_view_cocoa_unittest.mm

Bug:  743095 
Change-Id: I636cbd193f72e7e1f79c9535d85d5fc5d00ce230
Reviewed-on: https://chromium-review.googlesource.com/572149
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488524}
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/about_flags.cc
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/ui/autofill/autofill_popup_layout_model.h
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
[add] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa_unittest.mm
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm
[add] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/ui/cocoa/web_textfield_touch_bar_controller.h
[add] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/browser/ui/cocoa/web_textfield_touch_bar_controller.mm
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/chrome/test/BUILD.gn
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/ui/base/cocoa/touch_bar_util.h
[modify] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/ui/base/cocoa/touch_bar_util.mm

Status: Fixed (was: Started)

Sign in to add a comment