LaserPointerView is a highly efficient implementation of a specific palette tool. It would be useful to extract parts not specific to a laser pointer into a base class that could be used to implement similar palette tools without code duplication.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04424852895156ea1aff5a02e72dc2fcb5f569ff commit 04424852895156ea1aff5a02e72dc2fcb5f569ff Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Wed Jul 19 22:54:50 2017 Extract reusable base from LaserPointerView The new FastInkView class contains everything required for low-latency rendering of pointer-like objects. Bug: 743083 Change-Id: I0d31451899078875acd906396dda945bb45f2189 Reviewed-on: https://chromium-review.googlesource.com/576389 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488020} [modify] https://crrev.com/04424852895156ea1aff5a02e72dc2fcb5f569ff/ash/BUILD.gn [add] https://crrev.com/04424852895156ea1aff5a02e72dc2fcb5f569ff/ash/fast_ink/DEPS [add] https://crrev.com/04424852895156ea1aff5a02e72dc2fcb5f569ff/ash/fast_ink/fast_ink_view.cc [add] https://crrev.com/04424852895156ea1aff5a02e72dc2fcb5f569ff/ash/fast_ink/fast_ink_view.h [modify] https://crrev.com/04424852895156ea1aff5a02e72dc2fcb5f569ff/ash/laser/DEPS [modify] https://crrev.com/04424852895156ea1aff5a02e72dc2fcb5f569ff/ash/laser/laser_pointer_view.cc [modify] https://crrev.com/04424852895156ea1aff5a02e72dc2fcb5f569ff/ash/laser/laser_pointer_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfd37409392f1cc986ff3423696deedc80fbfedb commit cfd37409392f1cc986ff3423696deedc80fbfedb Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Tue Jul 25 04:12:36 2017 Extract prediction logic from LaserPointerView Renamed LaserPointerPoints to FastInkPoints and move it under ash/fast_ink. Moved prediction logic into FastInkPoints. Added a unit test for prediction. This should allow other tools such as highlighter to use the common prediction logic. Bug: 743083 Change-Id: I2dc1c9dfb09d816f3eb9bf7cc83e8c777a38da06 Reviewed-on: https://chromium-review.googlesource.com/580612 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#489227} [modify] https://crrev.com/cfd37409392f1cc986ff3423696deedc80fbfedb/ash/BUILD.gn [add] https://crrev.com/cfd37409392f1cc986ff3423696deedc80fbfedb/ash/fast_ink/fast_ink_points.cc [add] https://crrev.com/cfd37409392f1cc986ff3423696deedc80fbfedb/ash/fast_ink/fast_ink_points.h [add] https://crrev.com/cfd37409392f1cc986ff3423696deedc80fbfedb/ash/fast_ink/fast_ink_points_unittest.cc [modify] https://crrev.com/cfd37409392f1cc986ff3423696deedc80fbfedb/ash/laser/DEPS [modify] https://crrev.com/cfd37409392f1cc986ff3423696deedc80fbfedb/ash/laser/laser_pointer_controller_test_api.cc [modify] https://crrev.com/cfd37409392f1cc986ff3423696deedc80fbfedb/ash/laser/laser_pointer_controller_test_api.h [modify] https://crrev.com/cfd37409392f1cc986ff3423696deedc80fbfedb/ash/laser/laser_pointer_controller_unittest.cc [delete] https://crrev.com/50ccafde647905f95176e03d938fdbce4292d694/ash/laser/laser_pointer_points.cc [delete] https://crrev.com/50ccafde647905f95176e03d938fdbce4292d694/ash/laser/laser_pointer_points.h [delete] https://crrev.com/50ccafde647905f95176e03d938fdbce4292d694/ash/laser/laser_pointer_points_test_api.cc [delete] https://crrev.com/50ccafde647905f95176e03d938fdbce4292d694/ash/laser/laser_pointer_points_test_api.h [delete] https://crrev.com/50ccafde647905f95176e03d938fdbce4292d694/ash/laser/laser_pointer_points_unittest.cc [modify] https://crrev.com/cfd37409392f1cc986ff3423696deedc80fbfedb/ash/laser/laser_pointer_view.cc [modify] https://crrev.com/cfd37409392f1cc986ff3423696deedc80fbfedb/ash/laser/laser_pointer_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9 commit 9494beb1a21edaaf1d0a9df520372e5b44bfd9b9 Author: nainar <nainar@chromium.org> Date: Tue Jul 25 05:10:07 2017 Revert "Extract prediction logic from LaserPointerView" This reverts commit cfd37409392f1cc986ff3423696deedc80fbfedb. Reason for revert: causing compile failure on https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Builder/builds/2108 Log here: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Builder%2F2108%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > Extract prediction logic from LaserPointerView > > Renamed LaserPointerPoints to FastInkPoints and > move it under ash/fast_ink. > > Moved prediction logic into FastInkPoints. > > Added a unit test for prediction. > > This should allow other tools such as highlighter > to use the common prediction logic. > > Bug: 743083 > Change-Id: I2dc1c9dfb09d816f3eb9bf7cc83e8c777a38da06 > Reviewed-on: https://chromium-review.googlesource.com/580612 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> > Cr-Commit-Position: refs/heads/master@{#489227} TBR=kaznacheev@chromium.org,reveman@chromium.org,oshima@chromium.org Change-Id: I1f3b2228b1099b70f85d731bf4716d3ea89cfca8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 743083 Reviewed-on: https://chromium-review.googlesource.com/583690 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#489235} [modify] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/BUILD.gn [delete] https://crrev.com/3f5bb40268a53183a6a80116d5a08b3934aca48c/ash/fast_ink/fast_ink_points.cc [delete] https://crrev.com/3f5bb40268a53183a6a80116d5a08b3934aca48c/ash/fast_ink/fast_ink_points.h [delete] https://crrev.com/3f5bb40268a53183a6a80116d5a08b3934aca48c/ash/fast_ink/fast_ink_points_unittest.cc [modify] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/laser/DEPS [modify] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/laser/laser_pointer_controller_test_api.cc [modify] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/laser/laser_pointer_controller_test_api.h [modify] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/laser/laser_pointer_controller_unittest.cc [add] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/laser/laser_pointer_points.cc [add] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/laser/laser_pointer_points.h [add] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/laser/laser_pointer_points_test_api.cc [add] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/laser/laser_pointer_points_test_api.h [add] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/laser/laser_pointer_points_unittest.cc [modify] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/laser/laser_pointer_view.cc [modify] https://crrev.com/9494beb1a21edaaf1d0a9df520372e5b44bfd9b9/ash/laser/laser_pointer_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe69015356c180b84ba1f520626b4772957a088a commit fe69015356c180b84ba1f520626b4772957a088a Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Tue Jul 25 21:04:42 2017 Reland: Extract prediction logic from LaserPointerView (Added a missing include that MSAN bots seem to require) Renamed LaserPointerPoints to FastInkPoints and move it under ash/fast_ink. Moved prediction logic into FastInkPoints. Added a unit test for prediction. This should allow other tools such as highlighter to use the common prediction logic. TBR=oshima@chromium.org Bug: 743083 Change-Id: Iaa626a00c01188fd4aae468b47c0e44e8f29235b Reviewed-on: https://chromium-review.googlesource.com/585267 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#489428} [modify] https://crrev.com/fe69015356c180b84ba1f520626b4772957a088a/ash/BUILD.gn [add] https://crrev.com/fe69015356c180b84ba1f520626b4772957a088a/ash/fast_ink/fast_ink_points.cc [add] https://crrev.com/fe69015356c180b84ba1f520626b4772957a088a/ash/fast_ink/fast_ink_points.h [add] https://crrev.com/fe69015356c180b84ba1f520626b4772957a088a/ash/fast_ink/fast_ink_points_unittest.cc [modify] https://crrev.com/fe69015356c180b84ba1f520626b4772957a088a/ash/laser/DEPS [modify] https://crrev.com/fe69015356c180b84ba1f520626b4772957a088a/ash/laser/laser_pointer_controller_test_api.cc [modify] https://crrev.com/fe69015356c180b84ba1f520626b4772957a088a/ash/laser/laser_pointer_controller_test_api.h [modify] https://crrev.com/fe69015356c180b84ba1f520626b4772957a088a/ash/laser/laser_pointer_controller_unittest.cc [delete] https://crrev.com/5f54795c5e4848eca77835c2ac79c685c675315e/ash/laser/laser_pointer_points.cc [delete] https://crrev.com/5f54795c5e4848eca77835c2ac79c685c675315e/ash/laser/laser_pointer_points.h [delete] https://crrev.com/5f54795c5e4848eca77835c2ac79c685c675315e/ash/laser/laser_pointer_points_test_api.cc [delete] https://crrev.com/5f54795c5e4848eca77835c2ac79c685c675315e/ash/laser/laser_pointer_points_test_api.h [delete] https://crrev.com/5f54795c5e4848eca77835c2ac79c685c675315e/ash/laser/laser_pointer_points_unittest.cc [modify] https://crrev.com/fe69015356c180b84ba1f520626b4772957a088a/ash/laser/laser_pointer_view.cc [modify] https://crrev.com/fe69015356c180b84ba1f520626b4772957a088a/ash/laser/laser_pointer_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9409d74e28b41488d7ac47915e703ade356f5209 commit 9409d74e28b41488d7ac47915e703ade356f5209 Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Thu Aug 03 00:48:14 2017 Reland: Extract prediction logic from LaserPointerView (Added a missing include that MSAN bots seem to require) Renamed LaserPointerPoints to FastInkPoints and move it under ash/fast_ink. Moved prediction logic into FastInkPoints. Added a unit test for prediction. This should allow other tools such as highlighter to use the common prediction logic. TBR=kaznacheev@google.com, oshima@chromium.org (cherry picked from commit fe69015356c180b84ba1f520626b4772957a088a) Bug: 743083 Change-Id: Iaa626a00c01188fd4aae468b47c0e44e8f29235b Reviewed-on: https://chromium-review.googlesource.com/585267 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489428} Reviewed-on: https://chromium-review.googlesource.com/599407 Cr-Commit-Position: refs/branch-heads/3163@{#256} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/9409d74e28b41488d7ac47915e703ade356f5209/ash/BUILD.gn [add] https://crrev.com/9409d74e28b41488d7ac47915e703ade356f5209/ash/fast_ink/fast_ink_points.cc [add] https://crrev.com/9409d74e28b41488d7ac47915e703ade356f5209/ash/fast_ink/fast_ink_points.h [add] https://crrev.com/9409d74e28b41488d7ac47915e703ade356f5209/ash/fast_ink/fast_ink_points_unittest.cc [modify] https://crrev.com/9409d74e28b41488d7ac47915e703ade356f5209/ash/laser/DEPS [modify] https://crrev.com/9409d74e28b41488d7ac47915e703ade356f5209/ash/laser/laser_pointer_controller_test_api.cc [modify] https://crrev.com/9409d74e28b41488d7ac47915e703ade356f5209/ash/laser/laser_pointer_controller_test_api.h [modify] https://crrev.com/9409d74e28b41488d7ac47915e703ade356f5209/ash/laser/laser_pointer_controller_unittest.cc [delete] https://crrev.com/1bf862c7c88dd345294c3403091eb057faa7bfc1/ash/laser/laser_pointer_points.cc [delete] https://crrev.com/1bf862c7c88dd345294c3403091eb057faa7bfc1/ash/laser/laser_pointer_points.h [delete] https://crrev.com/1bf862c7c88dd345294c3403091eb057faa7bfc1/ash/laser/laser_pointer_points_test_api.cc [delete] https://crrev.com/1bf862c7c88dd345294c3403091eb057faa7bfc1/ash/laser/laser_pointer_points_test_api.h [delete] https://crrev.com/1bf862c7c88dd345294c3403091eb057faa7bfc1/ash/laser/laser_pointer_points_unittest.cc [modify] https://crrev.com/9409d74e28b41488d7ac47915e703ade356f5209/ash/laser/laser_pointer_view.cc [modify] https://crrev.com/9409d74e28b41488d7ac47915e703ade356f5209/ash/laser/laser_pointer_view.h
Comment 1 by bugdroid1@chromium.org
, Jul 19 2017