New issue
Advanced search Search tips

Issue 743071 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 741829



Sign in to add a comment

run_suite failing in test_push

Project Member Reported by akes...@chromium.org, Jul 14 2017

Issue description

Traceback (most recent call last):
  File "/usr/local/autotest/site_utils/run_suite.py", line 1997, in <module>
    sys.exit(main())
  File "/usr/local/autotest/site_utils/run_suite.py", line 1986, in main
    RETURN_CODES.get_string(result.return_code))
AttributeError: 'tuple' object has no attribute 'return_code'
 
Owner: ayatane@chromium.org
Cc: davidri...@chromium.org
This is blocking push-to-prod.
I really want to get a push done this morning to land an important run_suite logging fix, I'm going to prepare a revert and we can re-land the refactor CLs later.
Blocking: 741829
It's a simple fix making the tuples into the namedtuple: https://chromium-review.googlesource.com/c/572022/
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/096e1856666ecb97c8dc45a582bbc61b9b320fe0

commit 096e1856666ecb97c8dc45a582bbc61b9b320fe0
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jul 14 16:52:55 2017

[autotest] Use namedtuple

BUG= chromium:743071 
TEST=run_suite_unittest; local run_suite -m against a previous existing
suite

Change-Id: If3425514ab190ff036eeeb9d33311064aca91268
Reviewed-on: https://chromium-review.googlesource.com/572022
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/096e1856666ecb97c8dc45a582bbc61b9b320fe0/site_utils/run_suite.py

Status: Fixed (was: Untriaged)

Sign in to add a comment