New issue
Advanced search Search tips

Issue 743062 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

git cl format does not work on mac

Project Member Reported by gsat...@chromium.org, Jul 14 2017

Issue description

OS: OSX 10.12.5

What steps will reproduce the problem?
(1) Clone V8 https://github.com/v8/v8/wiki/Using-Git 
(2) Edit file
(3) git cl format .

What is the expected result?

The edited file is format

What happens instead?

Nothing happens

Please use labels and text to provide additional information.
➜  v8 (fix-iterator) ✗ git cl format . -vv
[D2017-07-14 08:31:14,522 74977 140736251433920 subprocess2.py] git rev-parse --show-cdup
[D2017-07-14 08:31:14,528 74977 140736251433920 subprocess2.py] git symbolic-ref HEAD
[D2017-07-14 08:31:14,534 74977 140736251433920 subprocess2.py] git config branch.fix-iterator.rietveldissue
[D2017-07-14 08:31:14,541 74977 140736251433920 subprocess2.py] git config branch.fix-iterator.gerritissue
[D2017-07-14 08:31:14,547 74977 140736251433920 subprocess2.py] git config rietveld.autoupdate
[D2017-07-14 08:31:14,554 74977 140736251433920 git_cl.py] Failed running ['git', 'config', 'rietveld.autoupdate']
[D2017-07-14 08:31:14,554 74977 140736251433920 subprocess2.py] git rev-parse --show-cdup
[D2017-07-14 08:31:14,561 74977 140736251433920 subprocess2.py] git config rietveld.cc v8-reviews@googlegroups.com
[D2017-07-14 08:31:14,570 74977 140736251433920 subprocess2.py] git config --unset-all rietveld.private
[D2017-07-14 08:31:14,579 74977 140736251433920 git_cl.py] Failed running ['git', 'config', '--unset-all', 'rietveld.private']
[D2017-07-14 08:31:14,579 74977 140736251433920 subprocess2.py] git config rietveld.tree-status-url http://v8-status.appspot.com/status
[D2017-07-14 08:31:14,588 74977 140736251433920 subprocess2.py] git config rietveld.viewvc-url https://chromium.googlesource.com/v8/v8/+/
[D2017-07-14 08:31:14,596 74977 140736251433920 subprocess2.py] git config --unset-all rietveld.bug-prefix
[D2017-07-14 08:31:14,603 74977 140736251433920 git_cl.py] Failed running ['git', 'config', '--unset-all', 'rietveld.bug-prefix']
[D2017-07-14 08:31:14,603 74977 140736251433920 subprocess2.py] git config --unset-all rietveld.cpplint-regex
[D2017-07-14 08:31:14,610 74977 140736251433920 git_cl.py] Failed running ['git', 'config', '--unset-all', 'rietveld.cpplint-regex']
[D2017-07-14 08:31:14,610 74977 140736251433920 subprocess2.py] git config --unset-all rietveld.cpplint-ignore-regex
[D2017-07-14 08:31:14,618 74977 140736251433920 git_cl.py] Failed running ['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex']
[D2017-07-14 08:31:14,618 74977 140736251433920 subprocess2.py] git config rietveld.project v8
[D2017-07-14 08:31:14,627 74977 140736251433920 subprocess2.py] git config rietveld.run-post-upload-hook True
[D2017-07-14 08:31:14,637 74977 140736251433920 subprocess2.py] git config gerrit.host True
[D2017-07-14 08:31:14,644 74977 140736251433920 subprocess2.py] git config gerrit.host
[D2017-07-14 08:31:14,651 74977 140736251433920 subprocess2.py] git config branch.fix-iterator.merge
[D2017-07-14 08:31:14,657 74977 140736251433920 subprocess2.py] git config rietveld.upstream-branch
[D2017-07-14 08:31:14,664 74977 140736251433920 git_cl.py] Failed running ['git', 'config', 'rietveld.upstream-branch']
[D2017-07-14 08:31:14,665 74977 140736251433920 subprocess2.py] git branch -r
[D2017-07-14 08:31:14,827 74977 140736251433920 subprocess2.py] git merge-base HEAD refs/remotes/origin/master
[D2017-07-14 08:31:14,842 74977 140736251433920 subprocess2.py] git diff --no-ext-diff --no-prefix --name-only db302014b6dcfd82722c28eb7a6e9446bc546542 -- /Users/gunasekaran/code/v8/.
[D2017-07-14 08:31:14,895 74977 140736251433920 subprocess2.py] git rev-parse --show-toplevel
[D2017-07-14 08:31:14,902 74977 140736251433920 subprocess2.py] git diff --no-ext-diff --no-prefix -U0 db302014b6dcfd82722c28eb7a6e9446bc546542 -- src/ic/ic.cc src/runtime/runtime-internal.cc src/runtime/runtime-object.cc src/runtime/runtime.h
[D2017-07-14 08:31:14,942 74977 140736251433920 subprocess2.py] /usr/bin/python /Users/gunasekaran/code/v8/buildtools/clang_format/script/clang-format-diff.py -p0 -i;  cwd=/Users/gunasekaran/code/v8
 
Components: -Infra Infra>SDK
Ok figured it out. This was broken because I had git config
  color.ui = always

Changing it to
  color.ui = auto

fixed it.

Maybe the clang-format script could check for this config and warn?

Comment 3 by aga...@chromium.org, Nov 14 2017

Status: WontFix (was: Untriaged)
clang-format is not owned by infra team, or even by chrome team. It is owned by LLVM.

Sign in to add a comment