New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 743049 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Task



Sign in to add a comment

DeleteInstance method for testing with the DesktopSessionDurationTracker

Project Member Reported by catherinechung@google.com, Jul 14 2017

Issue description

This method deletes the instance and resets it to nullptr to avoid
memory leaks in tests.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 17 2017

Labels: Hotlist-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e20eaff5a1370e290a8ac4923dfeefb40303b45e

commit e20eaff5a1370e290a8ac4923dfeefb40303b45e
Author: Catherine Chung <catherinechung@google.com>
Date: Wed Jul 19 21:32:04 2017

DeleteInstanceForTesting method for the DesktopSessionDurationTracker

This method deletes the instance and resets it to nullptr to avoid
memory leaks in tests.

Bug:  743049 
Change-Id: Ib14253155c2282dd8c4cedcc9bc25f7389ae7a28
Reviewed-on: https://chromium-review.googlesource.com/571504
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Catherine Chung <catherinechung@google.com>
Cr-Commit-Position: refs/heads/master@{#487994}
[modify] https://crrev.com/e20eaff5a1370e290a8ac4923dfeefb40303b45e/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker.cc
[modify] https://crrev.com/e20eaff5a1370e290a8ac4923dfeefb40303b45e/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker.h
[modify] https://crrev.com/e20eaff5a1370e290a8ac4923dfeefb40303b45e/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc

Sign in to add a comment