New issue
Advanced search Search tips

Issue 743048 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Jul 2017
Cc:
thakis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

git cl format doesn't do anything

Project Member Reported by rjkroege@chromium.org, Jul 14 2017 
I have an in-progress CL.

I ran git cl format. It made no changes. 

I did git cl upload and I get lots of valid formatting complaints. But see above: git cl format has been run. It use to fix this sort of thing.

How do I fix?

Comment 1 by rjkroege@chromium.org, Jul 14 2017

Cc: thakis@chromium.org
in particular: I had a tab in a source file. git cl format use to remove. Is this a clang-format bug? clang-format (in depot_tools) doesn't remove tabs when executed like this:

clang-format -style'='Chromium -i <source file containing a tab>

Comment 2 by rjkroege@chromium.org, Jul 14 2017

Status: WontFix (was: Untriaged)
Oops. Non-issue. My fault.

Comment 3 by thakis@chromium.org, Jul 14 2017 

What was wrong?
►

Sign in to add a comment