New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 743014 link

Starred by 1 user
Status: Fixed
Owner:
█ vollick@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
tiborg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Add regression test for passing mouse moves while clicking to content.

Project Member Reported by mthiesse@chromium.org, Jul 14 2017 
The controller is too noisy and causes drag events to be started all the time instead of clicking links, which looks to the user like clicks don't work.

This has regressed once and been fixed twice so we should add a regression test. See  issue 741020  and  issue 732917 .
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac18515dcf32d484430bc1c7f2b35e60152b4ca0

commit ac18515dcf32d484430bc1c7f2b35e60152b4ca0
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Jul 17 16:20:32 2017

[vr] Apply content move suppression in UiInputManager

The change in https://chromium-review.googlesource.com/567384 did not
have exactly the same behaviour as the change in
https://codereview.chromium.org/2944453002. This CL moves the content
move suppression as per the previous CL and introduces a testing
framework for the UiInputManager.

Bug:  741020 ,  743014 
Change-Id: Idd8fb0a1c6fb3f74c24dc555b1a72e0c7c3bc611
Reviewed-on: https://chromium-review.googlesource.com/573100
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487104}
[modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/test/mock_browser_interface.cc
[add] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/test/mock_browser_interface.h
[add] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/test/ui_scene_manager_test.cc
[add] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/test/ui_scene_manager_test.h
[modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/ui_input_manager.h
[add] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/ui_renderer.cc
[modify] https://crrev.com/ac18515dcf32d484430bc1c7f2b35e60152b4ca0/chrome/browser/vr/ui_scene_manager_unittest.cc

Comment 2 by mthiesse@chromium.org, Jul 31 2017

Owner: vollick@chromium.org
vollick@, this can be considered fixed, right?

Comment 3 by vollick@chromium.org, Jul 31 2017

Status: Fixed (was: Available)
►

Sign in to add a comment