New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 743009 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Jul 2017
Cc:
█ suzyh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Flaky zoom-responsive-transform-animation.html test

Project Member Reported by fhorschig@chromium.org, Jul 14 2017 
webkit_tests failing on chromium.webkit/WebKit Win7 (dbg)

Builders failed on WebKit Win7 (dbg): 
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29

latest:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10297
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10293

suzyh: Could you please help investigate the underlying issue? You seem to have some recent experience with these tests
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15b302f693b8cfdc9204879ff48c76150c49c11a

commit 15b302f693b8cfdc9204879ff48c76150c49c11a
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Jul 14 23:27:41 2017

Add flaky timeout expectation for zoom-responsive-transform-animation test

Reason for TBR: sheriffing, making the tree green

TBR: suzyh
Bug:  743009 
Change-Id: I3cceb99b3fa73bec5b4940f3f3f39ab737130a67
Reviewed-on: https://chromium-review.googlesource.com/572334
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486936}
[modify] https://crrev.com/15b302f693b8cfdc9204879ff48c76150c49c11a/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by mikelawther@chromium.org, Jul 16 2017

Cc: suzyh@chromium.org
Labels: Update-Monthly
Owner: ----
Status: Available (was: Assigned)
suzyh is no longer working on Chrome.

Comment 3 by rogerta@chromium.org, Jul 17 2017

Labels: -Sheriff-Chromium
Owner: ericwilligers@chromium.org
Status: Assigned (was: Available)
The most recent occurrence of flakes from the set of tests that flaked originally:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10318

Still seems to have timed out even though timeout expectation was changed in comment #1.

Eric: can you please take a look?  Thanks.

Comment 4 by ericwilligers@chromium.org, Jul 18 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfec8a9dca35c11a8ddf082785500c6231ec7afc

commit dfec8a9dca35c11a8ddf082785500c6231ec7afc
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Tue Jul 18 03:17:24 2017

Fix flaky zoom-responsive-transform-animation.html

We ensure the new zoom factor has been processed by the compositor,
using requestAnimationFrame and a finished promise.

BUG= 743009 

Change-Id: I5d6b97333d170ceaa6bcd29db3e84446ef59d18b
Reviewed-on: https://chromium-review.googlesource.com/575729
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487369}
[modify] https://crrev.com/dfec8a9dca35c11a8ddf082785500c6231ec7afc/third_party/WebKit/LayoutTests/animations/responsive/zoom-responsive-transform-animation-expected.html
[modify] https://crrev.com/dfec8a9dca35c11a8ddf082785500c6231ec7afc/third_party/WebKit/LayoutTests/animations/responsive/zoom-responsive-transform-animation.html

Comment 6 by ericwilligers@chromium.org, Jul 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment