https://docs.google.com/presentation/d/1rwEU7POtwRQB24EOSLrxEfz0NcOU9pP7TdMKNjIpV-s/edit#slide=id.g21d6fab901_1_156
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8c3757e2d8d239d653da008ea6faffce296b854 commit a8c3757e2d8d239d653da008ea6faffce296b854 Author: Tommy Steimel <steimel@chromium.org> Date: Thu Aug 24 00:15:46 2017 Implement Desktop UI for Site Muting This CL adds desktop UI that uses the sound content setting to mute and unmute WebContents. This is hidden behind a feature flag (kSoundContentSetting). Bug: 743001 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If685718e2b5f69d8480b40d5d80a8a64cf7ca13e Reviewed-on: https://chromium-review.googlesource.com/580112 Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#496881} [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/app/generated_resources.grd [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/app/settings_strings.grdp [add] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/app/theme/default_100_percent/common/allowed_sound.png [add] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/app/theme/default_100_percent/common/blocked_sound.png [add] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/app/theme/default_200_percent/common/allowed_sound.png [add] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/app/theme/default_200_percent/common/blocked_sound.png [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/content_settings/sound_content_setting_observer.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/content_settings/sound_content_setting_observer_unittest.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/extensions/extension_tab_util.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/resources/settings/route.js [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/resources/settings/site_settings/category_default_setting.js [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/resources/settings/site_settings/constants.js [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/resources/settings/site_settings_page/site_settings_page.html [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/resources/settings/site_settings_page/site_settings_page.js [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/ui/browser_commands.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/ui/page_info/page_info.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/ui/page_info/page_info_ui.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/ui/tab_helpers.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/ui/tabs/tab_menu_model.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/ui/tabs/tab_strip_model.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/ui/tabs/tab_strip_model.h [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/ui/tabs/tab_utils.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/ui/tabs/tab_utils.h [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/browser/ui/webui/site_settings_helper.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/common/chrome_features.cc [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/common/chrome_features.h [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/test/data/webui/settings/all_sites_tests.js [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/test/data/webui/settings/site_details_tests.js [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/test/data/webui/settings/site_list_tests.js [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js [modify] https://crrev.com/a8c3757e2d8d239d653da008ea6faffce296b854/components/page_info_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77704bea397c70cdc7c054474b64b6162ae87d10 commit 77704bea397c70cdc7c054474b64b6162ae87d10 Author: Tommy Steimel <steimel@chromium.org> Date: Mon Aug 28 22:14:40 2017 Add SoundContentSetting to about_flags. Also add Sound to site_details page. Bug: 743001 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I43092e0bc7861d62c87851e2c15f127ca3f49a18 Reviewed-on: https://chromium-review.googlesource.com/633464 Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#497897} [modify] https://crrev.com/77704bea397c70cdc7c054474b64b6162ae87d10/chrome/browser/about_flags.cc [modify] https://crrev.com/77704bea397c70cdc7c054474b64b6162ae87d10/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/77704bea397c70cdc7c054474b64b6162ae87d10/chrome/browser/flag_descriptions.h [modify] https://crrev.com/77704bea397c70cdc7c054474b64b6162ae87d10/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/77704bea397c70cdc7c054474b64b6162ae87d10/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/77704bea397c70cdc7c054474b64b6162ae87d10/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/616785edd4ca13d7d1da91f98a727af8d4f433fc commit 616785edd4ca13d7d1da91f98a727af8d4f433fc Author: Tommy Steimel <steimel@chromium.org> Date: Fri Sep 29 00:55:44 2017 Change Blocked list header to Muted for sound content setting Bug: 743001 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id07bbc5a0afe968ca448a0b32855d104b7322211 Reviewed-on: https://chromium-review.googlesource.com/688818 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#505235} [modify] https://crrev.com/616785edd4ca13d7d1da91f98a727af8d4f433fc/chrome/app/settings_strings.grdp [modify] https://crrev.com/616785edd4ca13d7d1da91f98a727af8d4f433fc/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/616785edd4ca13d7d1da91f98a727af8d4f433fc/chrome/browser/resources/settings/site_settings/category_setting_exceptions.html [modify] https://crrev.com/616785edd4ca13d7d1da91f98a727af8d4f433fc/chrome/browser/resources/settings/site_settings/category_setting_exceptions.js [modify] https://crrev.com/616785edd4ca13d7d1da91f98a727af8d4f433fc/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0056a2790d9382b9ae5c7d9b2d53e5ae78d7543 commit c0056a2790d9382b9ae5c7d9b2d53e5ae78d7543 Author: Tommy Steimel <steimel@chromium.org> Date: Fri Oct 13 21:20:34 2017 Update language for sound content setting on desktop Bug: 743001 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic334d91b9d3e9043ae717b84158fc99436f5e007 Reviewed-on: https://chromium-review.googlesource.com/719338 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#508822} [modify] https://crrev.com/c0056a2790d9382b9ae5c7d9b2d53e5ae78d7543/chrome/app/settings_strings.grdp [modify] https://crrev.com/c0056a2790d9382b9ae5c7d9b2d53e5ae78d7543/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/c0056a2790d9382b9ae5c7d9b2d53e5ae78d7543/chrome/browser/resources/settings/site_settings_page/site_settings_page.html [modify] https://crrev.com/c0056a2790d9382b9ae5c7d9b2d53e5ae78d7543/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
adding screenshots of the UI
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bee58d8cc08debda0ea2d40a9d41a09b6f165a9 commit 4bee58d8cc08debda0ea2d40a9d41a09b6f165a9 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Oct 18 15:35:37 2017 Enable SoundContentSetting feature Bug: 743001 , 743000 Change-Id: I5e17fd023ad75657c98b286ea40ff6b4e81acdd1 Reviewed-on: https://chromium-review.googlesource.com/722445 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#509776} [modify] https://crrev.com/4bee58d8cc08debda0ea2d40a9d41a09b6f165a9/chrome/browser/media/media_engagement_browsertest.cc [modify] https://crrev.com/4bee58d8cc08debda0ea2d40a9d41a09b6f165a9/chrome/common/chrome_features.cc
Is there anything missing here?
No, should be good to close. Any modifications can be in a new bug
Can u deploy mute site AND mute tab? Usefull to watch streams (mute tab), and wont lost mute site function
Comment 1 by mlamouri@chromium.org
, Jul 14 2017