UI mocks: https://docs.google.com/presentation/d/1rwEU7POtwRQB24EOSLrxEfz0NcOU9pP7TdMKNjIpV-s/edit#slide=id.g21d6fab901_1_30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fb849623027d2213e581a5ceb3211c16ab848e9 commit 8fb849623027d2213e581a5ceb3211c16ab848e9 Author: Tommy Steimel <steimel@chromium.org> Date: Thu Sep 14 18:32:53 2017 Create Android UI for site muting Bug: 743000 Change-Id: I712b04585a3166d114aea924423348aa4e34d7fa Reviewed-on: https://chromium-review.googlesource.com/647733 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501995} [add] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/res/drawable-hdpi/ic_volume_up_grey600_24dp.png [add] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/res/drawable-mdpi/ic_volume_up_grey600_24dp.png [add] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/res/drawable-xhdpi/ic_volume_up_grey600_24dp.png [add] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/res/drawable-xxhdpi/ic_volume_up_grey600_24dp.png [add] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/res/drawable-xxxhdpi/ic_volume_up_grey600_24dp.png [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/res/xml/single_website_preferences.xml [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/res/xml/site_settings_preferences.xml [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsCategory.java [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/browser/about_flags.cc [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/8fb849623027d2213e581a5ceb3211c16ab848e9/chrome/browser/ui/tab_helpers.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39b16347f4af5f097da70fdc3e8f623b6d94ab58 commit 39b16347f4af5f097da70fdc3e8f623b6d94ab58 Author: Tommy Steimel <steimel@chromium.org> Date: Fri Oct 13 15:54:31 2017 Show sound content setting in page info on Android Currently, even if the sound content setting is in a non-default state, we don't show it in page info on Android. This CL fixes that oversight. Bug: 743000 Change-Id: Icf7b0ca7db1ca63faa5b93787036bf8cb53370b4 Reviewed-on: https://chromium-review.googlesource.com/717419 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#508713} [modify] https://crrev.com/39b16347f4af5f097da70fdc3e8f623b6d94ab58/chrome/browser/ui/android/page_info/page_info_popup_android.cc
Attaching some screenshots of the UI
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af6a11f9b8fdd9346fd834a81eecb0a97be263a9 commit af6a11f9b8fdd9346fd834a81eecb0a97be263a9 Author: Tommy Steimel <steimel@chromium.org> Date: Fri Oct 13 23:59:12 2017 Allow users to set the default content setting for sound on Android Bug: 743000 Change-Id: Iec713fc8474e86cf5aa122d075063f968b0fb506 Reviewed-on: https://chromium-review.googlesource.com/717316 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#508879} [modify] https://crrev.com/af6a11f9b8fdd9346fd834a81eecb0a97be263a9/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java [modify] https://crrev.com/af6a11f9b8fdd9346fd834a81eecb0a97be263a9/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java [modify] https://crrev.com/af6a11f9b8fdd9346fd834a81eecb0a97be263a9/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java [modify] https://crrev.com/af6a11f9b8fdd9346fd834a81eecb0a97be263a9/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java [modify] https://crrev.com/af6a11f9b8fdd9346fd834a81eecb0a97be263a9/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/af6a11f9b8fdd9346fd834a81eecb0a97be263a9/chrome/browser/android/preferences/pref_service_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bee58d8cc08debda0ea2d40a9d41a09b6f165a9 commit 4bee58d8cc08debda0ea2d40a9d41a09b6f165a9 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Oct 18 15:35:37 2017 Enable SoundContentSetting feature Bug: 743001 , 743000 Change-Id: I5e17fd023ad75657c98b286ea40ff6b4e81acdd1 Reviewed-on: https://chromium-review.googlesource.com/722445 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#509776} [modify] https://crrev.com/4bee58d8cc08debda0ea2d40a9d41a09b6f165a9/chrome/browser/media/media_engagement_browsertest.cc [modify] https://crrev.com/4bee58d8cc08debda0ea2d40a9d41a09b6f165a9/chrome/common/chrome_features.cc
Is there anything missing here?
No, should be good to close. Any modifications can be in a new bug
Comment 1 by mlamouri@chromium.org
, Jul 14 2017