New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 742999 link

Starred by 10 users
Status: Fixed
Owner:
steimel@chromium.org
Closed: Jul 2017
Cc:
guidou@chromium.org
dominickn@chromium.org
█ kcaratt...@chromium.org
emilyschechter@chromium.org
█ apaci...@chromium.org
msramek@chromium.org
finnur@chromium.org
█ raymes@chromium.org
█ rachelis@chromium.org
█ ainslie@chromium.org
beccahughes@chromium.org
mlamouri@chromium.org
█ dah...@chromium.org
ojan@chromium.org
█ renganat...@chromium.org
benwells@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature
Team-Security-UX

Blocking:
issue 743000
issue 743001



Sign in to add a comment

Implement sound content settings to block sound output from a website

Project Member Reported by mlamouri@chromium.org, Jul 14 2017 
UI mocks:
https://docs.google.com/presentation/d/1rwEU7POtwRQB24EOSLrxEfz0NcOU9pP7TdMKNjIpV-s/edit#slide=id.g21d6fab901_1_30

It should default to enabled and when blocked, the origin should become inaudible.

Comment 1 by mlamouri@chromium.org, Jul 14 2017

Blocking: 743000

Comment 2 by mlamouri@chromium.org, Jul 14 2017

Blocking: 743001

Comment 3 by mlamouri@chromium.org, Jul 14 2017

Labels: -Type-Bug Type-Feature

Comment 4 by dullweber@chromium.org, Jul 17 2017

Components: Privacy

Comment 5 by msramek@chromium.org, Jul 17 2017

Components: UI>Browser>SiteSettings

Comment 6 by steimel@chromium.org, Jul 18 2017

Cc: finnur@chromium.org ojan@chromium.org ainslie@chromium.org renganat...@chromium.org benwells@chromium.org msramek@chromium.org guidou@chromium.org raymes@chromium.org rachelis@chromium.org emilyschechter@chromium.org dominickn@chromium.org kcaratt...@chromium.org
 Issue 640129  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f976a677fcff3736e3b9c2713f0a632a0c286b6

commit 2f976a677fcff3736e3b9c2713f0a632a0c286b6
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Jul 18 19:16:39 2017

Add new content setting for sound

This CL does not display the setting on any UI.
This setting is used to mute websites.

Bug:  742999 
Change-Id: I4c15c809795b523b90a26f4b42b3d0b9d612d695
Reviewed-on: https://chromium-review.googlesource.com/570807
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487550}
[modify] https://crrev.com/2f976a677fcff3736e3b9c2713f0a632a0c286b6/chrome/browser/BUILD.gn
[add] https://crrev.com/2f976a677fcff3736e3b9c2713f0a632a0c286b6/chrome/browser/content_settings/sound_content_setting_observer.cc
[add] https://crrev.com/2f976a677fcff3736e3b9c2713f0a632a0c286b6/chrome/browser/content_settings/sound_content_setting_observer.h
[add] https://crrev.com/2f976a677fcff3736e3b9c2713f0a632a0c286b6/chrome/browser/content_settings/sound_content_setting_observer_unittest.cc
[modify] https://crrev.com/2f976a677fcff3736e3b9c2713f0a632a0c286b6/chrome/test/BUILD.gn
[modify] https://crrev.com/2f976a677fcff3736e3b9c2713f0a632a0c286b6/components/content_settings/core/browser/content_settings_registry.cc
[modify] https://crrev.com/2f976a677fcff3736e3b9c2713f0a632a0c286b6/components/content_settings/core/common/content_settings.cc
[modify] https://crrev.com/2f976a677fcff3736e3b9c2713f0a632a0c286b6/components/content_settings/core/common/content_settings_types.h

Comment 8 by steimel@chromium.org, Jul 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment