New issue
Advanced search Search tips

Issue 742991 link

Starred by 1 user
Status: Fixed
Owner:
xidac...@chromium.org
Closed: Jul 2017
Cc:
flackr@chromium.org
ikilpatrick@chromium.org
fmalita@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Improve the css-paint-api/ layout tests

Project Member Reported by xidac...@chromium.org, Jul 14 2017 
All the layout tests under wpt/css-paint-api/ are ref tests, and most of the tests look like this:
Test whether a property is getting the right value or not, if the value is correct, stroke a green rect, otherwise, stroke a red rect.

Because skia is making changes to AA algorithms, this kind of tests become fragile. We could use fillRect instead of stroke rect.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/decbf668f7b2e656acbceda0747077343e44db50

commit decbf668f7b2e656acbceda0747077343e44db50
Author: Xida Chen <xidachen@chromium.org>
Date: Fri Jul 14 18:16:02 2017

Make two tests under css-paint-api/ pass

After this change: https://chromium-review.googlesource.com/c/570003/,
two layout tests under css-paint-api/ starts failing.

I found that the common thing with these two tests is that there is a
repeat-x or repeat-y in the css style. Not sure why that causes the
failure.

Instead, this CL changes it to fill a rect, which will be less sensitive
to AA changes.

Bug:  742991 
Change-Id: I16e4cddbcbd466852d43a07d658460f4e07e6a47
Reviewed-on: https://chromium-review.googlesource.com/571027
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486810}
[modify] https://crrev.com/decbf668f7b2e656acbceda0747077343e44db50/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/decbf668f7b2e656acbceda0747077343e44db50/third_party/WebKit/LayoutTests/external/wpt/css-paint-api/background-image-tiled-ref.html
[modify] https://crrev.com/decbf668f7b2e656acbceda0747077343e44db50/third_party/WebKit/LayoutTests/external/wpt/css-paint-api/background-image-tiled.html
[modify] https://crrev.com/decbf668f7b2e656acbceda0747077343e44db50/third_party/WebKit/LayoutTests/external/wpt/css-paint-api/geometry-background-image-tiled-001-ref.html
[modify] https://crrev.com/decbf668f7b2e656acbceda0747077343e44db50/third_party/WebKit/LayoutTests/external/wpt/css-paint-api/geometry-background-image-tiled-001.html

Comment 2 by xidac...@chromium.org, Jul 14 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment