New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742990 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Emulated page is seen even after disabling mobile view

Project Member Reported by sc00335...@techmahindra.com, Jul 14 2017

Issue description

Chrome Version: 61.0.3157.0
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1)Launch chrome and open devtools[F12] on any page
(2)Emulate to Mobile view and select Nexus5x from device list >> Select Navigation keyboard option from Screen options
(3)Now enable/disable 2-3 times and observe page

NOTE: Even refreshing page page doesn't help.

This is a regression issue broken in M61.

Good Build: 61.0.3155.0 dev
Bad Build: 61.0.3156.0 dev

Issue is not seen in windows.

 
Actual_emulation.ogv
2.6 MB View Download
Expected_emulation.ogv
1.8 MB View Download

Comment 1 by ajha@chromium.org, Jul 14 2017

Status: Untriaged (was: Unconfirmed)
Didn't repro for me on Mac OS 10.12.5, chrome version: 61.0.3156.0. Looks to be Linux specific.
Labels: -Needs-Bisect hasbisect
Owner: pfeldman@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce this issue on Ubuntu 14.04 using chrome latest dev #61.0.3157.0. This issue is only able to reproduce if the screen resolution is ≤1366*768. 

Bisect Information:
---------------------
You are probably looking for a change made after 485930 (known good), but no later than 485935 (first known bad).

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/f8059bbc87dff273b3445a33c8e57c91d089ad31..474df01407e5d38c85364ae4d1709b8d9af16f16

From the above change log suspecting below change
https://chromium.googlesource.com/chromium/src/+/3b4c6874fc78f6e2da1e1578c2bc5cf5a78348c4

pfeldman@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38

commit cc099f72c9fe6f67590e70b2956e27a7b5e7ac38
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Thu Jul 20 23:09:00 2017

DevTools: do not set visible size while emulating in case of device mode.

Bug:  742990 
Change-Id: Ibe303f5e0f5a94015adad2b0d90de963b25d61fb
TBR: tsepez (removing params from ipc message)
Reviewed-on: https://chromium-review.googlesource.com/572222
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488472}
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/content/browser/devtools/protocol/emulation_handler.h
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/content/common/view_messages.h
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/content/renderer/devtools/render_widget_screen_metrics_emulator.cc
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/content/renderer/devtools/render_widget_screen_metrics_emulator.h
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/content/renderer/external_popup_menu.cc
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/content/renderer/external_popup_menu.h
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/content/renderer/render_widget.cc
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/Source/core/events/WebInputEventConversion.cpp
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/Source/core/events/WebInputEventConversionTest.cpp
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/cc099f72c9fe6f67590e70b2956e27a7b5e7ac38/third_party/WebKit/public/web/WebDeviceEmulationParams.h

Labels: Merge-Request-61
Status: Started (was: Assigned)
Running on Canary for 3+ days with no issue.
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 26 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by gov...@chromium.org, Jul 26 2017

Pls merge you change to M61 branch 3163 by 5:00 PM today, Wednesday if possible so we can take it in for next week M61 last dev release. Thank you.
Labels: -Hotlist-Merge-Approved -Merge-Approved-61
Status: Fixed (was: Started)
Turns out branch was cut after it.

Sign in to add a comment