New issue
Advanced search Search tips

Issue 742987 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 713137



Sign in to add a comment

[jumbo] blink_modules.dll is built without all the necessary linker flags

Project Member Reported by brat...@opera.com, Jul 14 2017

Issue description

With jumbo enabled for modules ( https://chromium-review.googlesource.com/c/568302/ ), blink_modules.dll (debug component build) is linked without some flags:

/MACHINE:X86 /SAFESEH /largeaddressaware /fastfail /FIXED:NO /ignore:4199 /ignore:4221 /NXCOMPAT /DYNAMICBASE:NO /INCREMENTAL /SUBSYSTEM:CONSOLE,5.01

The missing /ignore:4199 in particular causes 
LINK : warning LNK4199: /DELAYLOAD:cfgmgr32.dll ignored; no imports found from cfgmgr32.dll

but I'm pretty sure the rest of the flags are needed as well.

These flags come from the configurations "sdk_link", "common_linker_setup" and "default_incremental_linking" in build/config/win/BUILD.gn. Apparently they are lost somewhere.

 

Comment 1 by brat...@opera.com, Jul 14 2017

Blocking: 713137

Comment 2 by brat...@opera.com, Jul 14 2017

Cc: dpranke@chromium.org brucedaw...@chromium.org
Owner: brat...@opera.com
Status: Assigned (was: Available)

Comment 3 by brat...@opera.com, Jul 18 2017

Status: Fixed (was: Assigned)
jumbo_target did not have the correct set_defaults to match "component". I added a jumbo_component for now. This will be better solved with native gn support.

Sign in to add a comment