Flash when theme with dark background image but no background color is added |
|||||
Issue descriptionChrome Version:61.0.3157.0 OS:Ubuntu 14.04, Windows What steps will reproduce the problem? (1)Launch chrome and add any theme [Eg: Shine] (2)Go to incognito window and keep reloading and observe Expected:No flash should be seen Actual:Instead, flash is seen This is a Regression issue seen from M-58 Manual bisect info: ==================== Good build:58.0.2992.0 Bad build: 58.0.2993.0
,
Jul 14 2017
Providing per-revision bisect information below Bisect Information: --------------------- You are probably looking for a change made after 446009 (known good), but no later than 446010 (first known bad). Change Log URL: https://chromium.googlesource.com/chromium/src/+log/1a124a768b39571398886d2755de4932ee63291e..c782ea5b9c5d4e85c75ab8a2d601a088376cc1af From the above change log suspecting below change Review URL: https://codereview.chromium.org/2634413002 treib@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Jul 14 2017
This theme has a dark background image, but doesn't set a background *color*, so the background color is implicitly white. Since the image is loaded asynchronously, that causes the flash. That happens on the regular NTP too, not just on the incognito one. Example theme that does set a proper background color: https://chrome.google.com/webstore/detail/galaxy-view/dcbeddldohkakodfncjnkkjfojggbahp?hl=en The CL quoted above turned off caching for ThemeSource. IIUC, that is necessary to ensure correct (up-to-date) theme data. In any case, caching could at best mitigate the problem by providing theme data a bit faster; it couldn't really solve it. FWIW, I tried turning caching back on in trunk, and it didn't seem to help at all.
,
Aug 22 2017
Agreed with the comment 3. Caching just mitigated this problem, but essentially this is a problem that can be fixed in the manifest.json by providing colors properties. https://developer.chrome.com/extensions/themes Let me add estade and pkotwicz to the CC list just in case. They are OWNERS in chrome/browser/themes/ that implements the theme.
,
Aug 22 2017
Also I think if there are no objections, we want to close this as WontFix.
,
Aug 22 2017
Agreed. Not much Chrome can do here. (We *could* try to extract a suitable background color from the image, if the theme doesn't specify it. But that seem complicated and fragile, and I don't even know if the color is really unspecified in the theme, or just set to white by default.) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kavvaru@chromium.org
, Jul 14 2017Status: Untriaged (was: Unconfirmed)