Regression: Add Bookmark dialog is not closed on hitting ESC key |
|||||
Issue description
Chrome Version: 61.0.3157.0
OS: Ubuntu 14.04, win 7
Pre-Condition: Enable Material Design bookmarks flags
What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://bookmarks
(2)Click On add new bookmark option in 3 dot menu and overlay is displayed.
(3)Now click outside the dialogue box and press ESC key and observe.
Expected
When focus is outside dialogue window,Overlay should get closed by ESC key.
Actual
Instead overlay is not getting closed.
This is a regression issue broken in M-61.
===============================
Manual Bisect info:
Good Build: 61.0.3132.0
Bad Build: 61.0.3133.0
,
Jul 14 2017
Able to reproduce the issue on Mac 10.12.6 using chrome version 61.0.3156.0
,
Jul 14 2017
Providing per-revision bisect information below Good Build: 61.0.3132.0 (479900) Bad Build: 61.0.3133.0 (480259) Bisect Information: --------------------- You are probably looking for a change made after 479981 (known good), but no later than 479982 (first known bad). Change Log URL: https://chromium.googlesource.com/chromium/src/+log/2696d5a95cc63cb1cf460afbe1f94d4005e366e4..3ddd3bc92b1abb19ef0dc36d3cd976bb420c3000 From the above change log suspecting below change Review URL: https://codereview.chromium.org/2929053004 @tsergeant: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thanks!
,
Jul 17 2017
MD Bookmarks is not launching yet -> Not a release blocker
,
Jul 18 2017
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/109279fe9e9af7519b91c5fcc2e3e4216c050ae8 commit 109279fe9e9af7519b91c5fcc2e3e4216c050ae8 Author: Tim Sergeant <tsergeant@chromium.org> Date: Thu Jul 20 03:07:17 2017 MD Bookmarks: Disable keyboard shortcuts when a dialog is open Even though our dialogs are modal, it was still possible to execute keyboard commands on the background content by clicking on the dialog background, which refocuses the document body and allowed commands to execute. Bug: 742972 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I01f9cb3060fd6a91a6fa5a832578f3f245712e0c Reviewed-on: https://chromium-review.googlesource.com/575252 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#488116} [modify] https://crrev.com/109279fe9e9af7519b91c5fcc2e3e4216c050ae8/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/109279fe9e9af7519b91c5fcc2e3e4216c050ae8/chrome/browser/resources/md_bookmarks/dialog_focus_manager.js [modify] https://crrev.com/109279fe9e9af7519b91c5fcc2e3e4216c050ae8/chrome/test/data/webui/md_bookmarks/command_manager_test.js
,
Jul 20 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by divya.pa...@techmahindra.com
, Jul 14 20172.3 MB
2.3 MB View Download