New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742942 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

component:UI>Browser>... were renamed to component:UI>Extensions>...

Project Member Reported by battre@chromium.org, Jul 14 2017

Issue description

Observe that we don't have UI>Browser>Passwords on crbug.com anymore but instead UI>Extensions>Passwords.

Looks like UI>Browser was accidentally renamed. Labeling as P1 because this may break some triaging scripts.
 

Comment 1 by engedy@chromium.org, Jul 14 2017

Labels: -Pri-1 Pri-0
Note that *all* of UI>Browser was renamed. This will break saved queries for lots of folks.

I suppose this was unintentional, otherwise I would have expected an announcement of a change of such magnitude. Marking as P0.

Comment 2 by engedy@chromium.org, Jul 14 2017

Components: Infra
Labels: Infra-Troopers
Troopers, is this something you can help out with?

Comment 3 by engedy@chromium.org, Jul 14 2017

Cc: hablich@chromium.org
Owner: hablich@chromium.org
Status: Assigned (was: Untriaged)
Taking a look
According to the edit log of UI>Extensions the last change was made by dschuyler@:

"Last modified by dschuyler@chromium.org Today"

I could create a temporary component UI>Browser>Passwords until this change is rolled back for good but I am not sure how the temporary component might impede this.
Cc: aga...@chromium.org
Owner: dschuyler@chromium.org
Cc: lafo...@chromium.org jparent@chromium.org
Was the component UI>Extensions there before or was it a simple renaming from UI>Browser to UI>Extensions?

Plan of action after talking with jochen@:

1.) dschuyler@ or somebody from the monorail team does a renaming back to the original state
2.) If this has not happened within the next 24 hours I will manually create UI>Browser>Passwords and move everything from UI>Extensions>Passwords over there. 

Cc: jrobbins@chromium.org dschuyler@chromium.org
Renamed it back to UI>Browser.  Not quite sure how/why that got renamed, but it would probably be good to understand what led up to that so we can prevent it in the future.

Comment 11 by d...@chromium.org, Jul 14 2017

Labels: -Infra-Troopers
Removing this from trooper queue since the immediate problem is resolved.
#6 That was entirely a mistake. I'm sorry. 
#10 I was trying to find out how to add a component name and hand't found any docs about it. A good prevention step for me would have been an link form the list of components to procedure docs for adding a component. I eventually found 	
Admin>ComponentRequest and filed  Issue 742656  since I figured the presence of the Admin>ComponentRequest implied that would be part of the procedure. I did realize that I'd accidentally changed UI>Browser.
#9 That's true that UI>Extensions was not there. That was the kick-off that started my quest to find out how to have a component created, then the accidental name change that this bug is about.
#10 (in #13 I described the 'why', here I'll describe the 'how'): I'd found 
https://bugs.chromium.org/p/chromium/components/detail?component=UI%3EBrowser
by clicking "Development Process", then "Components", then "UI>Browser". I'd edited the "Name" UI>Browser to UI>Browser>Extensions, but I wasn't sure where to go from there. I don't recall if I'd clicked "Create new subcomponent", but I'm confident I had not intentionally clicked "Submit Changes". I think it's likely that I clicked "Create new subcomponent" since it appears to be a link (and therefore would not cause an action to occur like I'd expect a button to do). In the end I'd decided not to attempt add the component until I'd learned more about the process. But I must have caused some change based on the results in this bug.
Status: Fixed (was: Assigned)
Fixed by laforge@ (comment #10). I'm sorry this happened. Thank you to those that tracked it down and fixed my mistake.

Sign in to add a comment