New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742727 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted selection of text is seen on reset dialogue when clicked out side of the dialogue

Project Member Reported by divya.pa...@techmahindra.com, Jul 14 2017

Issue description

Chrome Version: 61.0.3157.0
OS: Ubuntu 14.04, win 7

What steps will reproduce the problem?
(1)Launch chrome>> Navigate to chrome://settings/
(2)Scroll down the page and click on Reset button
(3)Now click multiple times outside of the Rest dialogue window and observe

Expected 
Text should not be selected on the reset dialogue

Actual
Unwanted selection of text is seen on reset dialogue

This is a regression issue broken in M-61. 
===============================
Manual Bisect info:

Good Build: 61.0.3132.0 
Bad Build: 61.0.3133.0
 
Actual_Unwanted selection.ogv
1.2 MB View Download
Expected12.ogv
1.0 MB View Download
Description: Show this description

Comment 2 by ajha@chromium.org, Jul 14 2017

Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Issue is seen on the latest Mac canary(61.0.3156.0) as well.
Cc: gajendr...@samsung.com
Labels: -Needs-Bisect hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
Providing per-revision bisect information below

Bisect Information:
---------------------
You are probably looking for a change made after 479981 (known good), but no later than 479982 (first known bad).

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/f5f880c3d9d32f6925c211cd4836701cd2a3cbb2..0721d307c2e650409d287b02ddeeed4d1635b086

From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2904783003

gajendra.n/dschuyler@ - Unable to find the authors name in the owners list, so assigning to the reviewer, Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 4 by dpa...@chromium.org, Jul 14 2017

Cc: dschuyler@chromium.org
Components: -UI UI>Settings
Labels: -Pri-1 Proj-MaterialDesign-WebUI Pri-2
Owner: dpa...@chromium.org
Status: Started (was: Assigned)
@dschuyler: Candidate fix at [1]. Assigning to myself since even though this was caused by the CL pointed out above, the fix is related to my recent changes at [2].

[1] https://chromium-review.googlesource.com/c/572205/
[2] https://chromium-review.googlesource.com/c/566093/
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e55240f16b4c3baaf9993aee48d8d2a82f7668f8

commit e55240f16b4c3baaf9993aee48d8d2a82f7668f8
Author: dpapad <dpapad@chromium.org>
Date: Mon Jul 17 19:47:35 2017

WebUI cr-dialog: Prevent text from being selected when clicking backdrop.

Bug:  742727 
Change-Id: Ia6bacffad903f7fd9d5a9e7d460dde293214b671
Reviewed-on: https://chromium-review.googlesource.com/572205
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487201}
[modify] https://crrev.com/e55240f16b4c3baaf9993aee48d8d2a82f7668f8/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

Comment 6 by dpa...@chromium.org, Jul 17 2017

Status: Fixed (was: Started)

Comment 7 by sans...@etouch.net, Jul 26 2017

Labels: TE-Verified-61.0.3163.0 TE-Verified-61.0.3163.13
Note: Above issue is fixed on latest Dev #61.0.3163.13 on Windows, Mac and Linux OS
Refer the attached video
Fixed_video.mov
3.6 MB Download
Labels: -TE-Verified-61.0.3163.0 TE-Verified-M61

Sign in to add a comment