New issue
Advanced search Search tips

Issue 742726 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Realm on login screen doesn't align vertically with username

Project Member Reported by ljusten@chromium.org, Jul 14 2017

Issue description

Looks like the @realm.com is 2px higher than the username. It's hurting my eyes.
 
Owner: ljusten@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b9273633e64360208a947b7176d3b36dcb544a5

commit 1b9273633e64360208a947b7176d3b36dcb544a5
Author: Lutz Justen <ljusten@chromium.org>
Date: Mon Jul 24 09:42:32 2017

More UI tweaks for Active Directory enrollment and user auth

In CL:567007, the user name label on the Active Directory auth screen
was changed from "Username (e.g. user@example.com)" to "Username"
since the example overlapped with the domain, which was displayed as
well. However, the enrollment UI uses the same HTML code and the
example was removed there, too. This CL brings it back.

Also fixes an alignment issue where the example was 2px too high.

BUG= chromium:742726 , chromium:739280 
TEST=Tested on Linux box

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaa64c8610f9f720f770b5b7ed79e39371fb910f0
Reviewed-on: https://chromium-review.googlesource.com/579091
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488937}
[modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/resources/chromeos/login/gaia_input.css
[modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/resources/chromeos/login/offline_ad_login.html
[modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/resources/chromeos/login/offline_ad_login.js
[modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
[modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 31 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44dba5e01501b387dbf2f1c67207c84bc86f9299

commit 44dba5e01501b387dbf2f1c67207c84bc86f9299
Author: Pavol Marko <pmarko@chromium.org>
Date: Mon Jul 31 08:01:38 2017

[Merge to M61] More UI tweaks for Active Directory enrollment and user auth

Merge on behalf of ljusten@.

In CL:567007, the user name label on the Active Directory auth screen
was changed from "Username (e.g. user@example.com)" to "Username"
since the example overlapped with the domain, which was displayed as
well. However, the enrollment UI uses the same HTML code and the
example was removed there, too. This CL brings it back.

Also fixes an alignment issue where the example was 2px too high.

BUG= chromium:742726 , chromium:739280 
TEST=Tested on Linux box
TBR=ljusten@chromium.org, pmarko@chromium.org

(cherry picked from commit 1b9273633e64360208a947b7176d3b36dcb544a5)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaa64c8610f9f720f770b5b7ed79e39371fb910f0
Reviewed-on: https://chromium-review.googlesource.com/579091
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488937}
Reviewed-on: https://chromium-review.googlesource.com/593317
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#145}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/resources/chromeos/login/gaia_input.css
[modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/resources/chromeos/login/offline_ad_login.html
[modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/resources/chromeos/login/offline_ad_login.js
[modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
[modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment