DCHECK_CURRENTLY_ON misleading in protocol_handler_registry_unittest.cc |
|||
Issue descriptionDCHECK_CURRENTLY_ON will succeed for any thread label when run with TestBrowserThreadBundle with no additional threads because TestBrowserThreadBundle runs everything in one thread and MessageLoop.
,
Nov 13 2017
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8af6692a4f096f285833c5d5d365dd44b61f6b6e commit 8af6692a4f096f285833c5d5d365dd44b61f6b6e Author: Ben Wells <benwells@chromium.org> Date: Mon Nov 20 23:33:32 2017 Remove thread DCHECK from protocol handler unit tests. These DCHECKs don't do anything as unit tests simulate threading. Bug: 742725 Change-Id: I6b7aac02693145d25e4f820e7164a823269d501d Reviewed-on: https://chromium-review.googlesource.com/778643 Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#517989} [modify] https://crrev.com/8af6692a4f096f285833c5d5d365dd44b61f6b6e/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
,
Nov 20 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dtapu...@chromium.org
, Nov 10 2017