New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742724 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Export a metric if keyboard contents is not loaded for long time.

Project Member Reported by oka@chromium.org, Jul 14 2017

Issue description

Export an error metric if the keyboard state is LOADING_EXTENSION for long time.

 

Comment 1 by oka@chromium.org, Jul 14 2017

In addition to LOADING_EXTENSION, WILL_HIDE, SHOWING, HIDING.
This sounds great to me.
Sounds great! Thanks for doing this.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f1e860db69b639a3eff71398ed86c6a919b710a

commit 3f1e860db69b639a3eff71398ed86c6a919b710a
Author: oka@chromium.org <oka@chromium.org>
Date: Thu Jul 20 02:31:24 2017

Export erroneously lingering intermediate keyboard states

Export intermediate keyboard states as UMA if it's
lingering too long (5 seconds).

- Made the UMA be exported on HIDDEN
- Checked chrome:histograms and confirmed only HIDDEN is exported.

Bug:  742724 
Test: manually tested with a little tweak in the code.
Change-Id: I5954f1c169441ef80b70c08b3515cee1b11bfcb2
Reviewed-on: https://chromium-review.googlesource.com/572606
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488103}
[modify] https://crrev.com/3f1e860db69b639a3eff71398ed86c6a919b710a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3f1e860db69b639a3eff71398ed86c6a919b710a/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/3f1e860db69b639a3eff71398ed86c6a919b710a/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/3f1e860db69b639a3eff71398ed86c6a919b710a/ui/keyboard/keyboard_controller.h

Comment 5 by oka@chromium.org, Jul 20 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment