New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 742721 link

Starred by 1 user
Status: Verified
Owner:
█ oka@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
omrilio@chromium.org
█ blakeo@chromium.org
yhanada@chromium.org
pcovell@chromium.org
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

VirtualKeyboard.InitLatency.FirstLoad exports wrong value if the first show animation is cancelled

Project Member Reported by oka@chromium.org, Jul 14 2017 
In the following scenario, time between (1) to (4) is exported, which is not expected. We should export the time for (4).

(1) ShowKeyboard is called
(2) Before animation finishes, HideKeyboard is called
(3) time passes.
(4) ShowKeyboard is called and keyboard is actually shown.

I think we can just remove the if statement in MarkKeyboardLoadStated.
https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_util.cc?type=cs&sq=package:chromium&l=285
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/199fda5be5354a2dc4914437945b0f4d0891303b

commit 199fda5be5354a2dc4914437945b0f4d0891303b
Author: oka@chromium.org <oka@chromium.org>
Date: Fri Jul 14 09:37:37 2017

Make sure sane first load time UMA is exported.

In the following scenario, time between (1) to (4) was exported.
We should export the time for (4).

(1) ShowKeyboard is called
(2) Before animation finishes, HideKeyboard is called
(3) time passes.
(4) ShowKeyboard is called and keyboard is actually shown.

Bug:  742721 
Change-Id: I1fc3a92cea7bfce25e8efb407a3e41508a367c36
Reviewed-on: https://chromium-review.googlesource.com/571108
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486712}
[modify] https://crrev.com/199fda5be5354a2dc4914437945b0f4d0891303b/ui/keyboard/keyboard_util.cc

Comment 2 by oka@chromium.org, Jul 25 2017

Status: Fixed (was: Assigned)

Comment 3 by omrilio@chromium.org, Jul 26 2017 

Thank you for fixing this so quickly!

Comment 4 by kathrelk...@chromium.org, Aug 10 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment