New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742699 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Adjust the bounds in opened search box

Project Member Reported by weidongg@chromium.org, Jul 14 2017

Issue description

Adjust the bounds of SearchBoxView and SearchResultPageView based on the specs. 
1. Adjust the height of SearchResultTileItemView based on spec: https://screenshot.googleplex.com/AFQ5HnrMYch
2. Adjust the height of SearchBoxView based on spec: https://screenshot.googleplex.com/bGiXTCBUhdX
3. Adjust the width and height of SearchResultPageView based on spec: https://screenshot.googleplex.com/ykfwoEeMPTr
 
Cc: hejq@chromium.org
+hejq@, I think this would fix the issue you mentioned that the rating and price are partially hidden for play store apps.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ae6f9f50f23ee8f5007a850cdccb6f083ec6418

commit 7ae6f9f50f23ee8f5007a850cdccb6f083ec6418
Author: Weidong Guo <weidongg@chromium.org>
Date: Mon Jul 17 21:31:50 2017

Adjust the bounds in opened search box

Changes:
1. Adjust the height of SearchResultTileItemView based on spec:
https://screenshot.googleplex.com/AFQ5HnrMYch
2. Adjust the height of SearchBoxView based on spec:
https://screenshot.googleplex.com/bGiXTCBUhdX
3. Adjust the width and height of SearchResultPageView based on spec:
https://screenshot.googleplex.com/ykfwoEeMPTr

Screenshot: https://screenshot.googleplex.com/8AQ0XofWAhZ

BUG= 742699 

Change-Id: Iad10d029241f82ccf98b3bac7e8a50c597da1aa1
Reviewed-on: https://chromium-review.googlesource.com/572365
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487250}
[modify] https://crrev.com/7ae6f9f50f23ee8f5007a850cdccb6f083ec6418/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/7ae6f9f50f23ee8f5007a850cdccb6f083ec6418/ui/app_list/app_list_constants.h
[modify] https://crrev.com/7ae6f9f50f23ee8f5007a850cdccb6f083ec6418/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/7ae6f9f50f23ee8f5007a850cdccb6f083ec6418/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/7ae6f9f50f23ee8f5007a850cdccb6f083ec6418/ui/app_list/views/contents_view.h
[modify] https://crrev.com/7ae6f9f50f23ee8f5007a850cdccb6f083ec6418/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/7ae6f9f50f23ee8f5007a850cdccb6f083ec6418/ui/app_list/views/search_result_list_view.cc
[modify] https://crrev.com/7ae6f9f50f23ee8f5007a850cdccb6f083ec6418/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/7ae6f9f50f23ee8f5007a850cdccb6f083ec6418/ui/app_list/views/search_result_page_view.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e4bfa288a2f5b7bed5cc273469a1a60b91fece3

commit 5e4bfa288a2f5b7bed5cc273469a1a60b91fece3
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Mon Jul 17 23:37:05 2017

Revert "Adjust the bounds in opened search box"

This reverts commit 7ae6f9f50f23ee8f5007a850cdccb6f083ec6418.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 487250 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdhZTZmOWY1MGYyM2VlOGY1MDA3YTg1MGNkY2NiNmYwODNlYzY0MTgM

Sample Build: https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Builder%20%28dbg%29/89626

Original change's description:
> Adjust the bounds in opened search box
> 
> Changes:
> 1. Adjust the height of SearchResultTileItemView based on spec:
> https://screenshot.googleplex.com/AFQ5HnrMYch
> 2. Adjust the height of SearchBoxView based on spec:
> https://screenshot.googleplex.com/bGiXTCBUhdX
> 3. Adjust the width and height of SearchResultPageView based on spec:
> https://screenshot.googleplex.com/ykfwoEeMPTr
> 
> Screenshot: https://screenshot.googleplex.com/8AQ0XofWAhZ
> 
> BUG= 742699 
> 
> Change-Id: Iad10d029241f82ccf98b3bac7e8a50c597da1aa1
> Reviewed-on: https://chromium-review.googlesource.com/572365
> Commit-Queue: Weidong Guo <weidongg@chromium.org>
> Reviewed-by: Yury Khmel <khmel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487250}
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG= 742699 

Change-Id: Id9ba9992566802461da8d3c055b6f052d0f69056
Reviewed-on: https://chromium-review.googlesource.com/575358
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487286}
[modify] https://crrev.com/5e4bfa288a2f5b7bed5cc273469a1a60b91fece3/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/5e4bfa288a2f5b7bed5cc273469a1a60b91fece3/ui/app_list/app_list_constants.h
[modify] https://crrev.com/5e4bfa288a2f5b7bed5cc273469a1a60b91fece3/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/5e4bfa288a2f5b7bed5cc273469a1a60b91fece3/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/5e4bfa288a2f5b7bed5cc273469a1a60b91fece3/ui/app_list/views/contents_view.h
[modify] https://crrev.com/5e4bfa288a2f5b7bed5cc273469a1a60b91fece3/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/5e4bfa288a2f5b7bed5cc273469a1a60b91fece3/ui/app_list/views/search_result_list_view.cc
[modify] https://crrev.com/5e4bfa288a2f5b7bed5cc273469a1a60b91fece3/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/5e4bfa288a2f5b7bed5cc273469a1a60b91fece3/ui/app_list/views/search_result_page_view.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0821814f31ed1a0eaff2c292644c93ec513b7d5c

commit 0821814f31ed1a0eaff2c292644c93ec513b7d5c
Author: Weidong Guo <weidongg@chromium.org>
Date: Wed Jul 19 00:28:11 2017

Reland "Adjust the bounds in opened search box"

This is a reland of 7ae6f9f50f23ee8f5007a850cdccb6f083ec6418
Original change's description:
> Adjust the bounds in opened search box
> 
> Changes:
> 1. Adjust the height of SearchResultTileItemView based on spec:
> https://screenshot.googleplex.com/AFQ5HnrMYch
> 2. Adjust the height of SearchBoxView based on spec:
> https://screenshot.googleplex.com/bGiXTCBUhdX
> 3. Adjust the width and height of SearchResultPageView based on spec:
> https://screenshot.googleplex.com/ykfwoEeMPTr
> 
> Screenshot: https://screenshot.googleplex.com/8AQ0XofWAhZ
> 
> BUG= 742699 
> 
> Change-Id: Iad10d029241f82ccf98b3bac7e8a50c597da1aa1
> Reviewed-on: https://chromium-review.googlesource.com/572365
> Commit-Queue: Weidong Guo <weidongg@chromium.org>
> Reviewed-by: Yury Khmel <khmel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487250}

Bug:  742699 
Change-Id: I6716d1a3e0a6a1a7b0cb9b7b7776cdb969435a53
Reviewed-on: https://chromium-review.googlesource.com/575591
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487688}
[modify] https://crrev.com/0821814f31ed1a0eaff2c292644c93ec513b7d5c/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/0821814f31ed1a0eaff2c292644c93ec513b7d5c/ui/app_list/app_list_constants.h
[modify] https://crrev.com/0821814f31ed1a0eaff2c292644c93ec513b7d5c/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/0821814f31ed1a0eaff2c292644c93ec513b7d5c/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/0821814f31ed1a0eaff2c292644c93ec513b7d5c/ui/app_list/views/contents_view.h
[modify] https://crrev.com/0821814f31ed1a0eaff2c292644c93ec513b7d5c/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/0821814f31ed1a0eaff2c292644c93ec513b7d5c/ui/app_list/views/search_result_list_view.cc
[modify] https://crrev.com/0821814f31ed1a0eaff2c292644c93ec513b7d5c/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/0821814f31ed1a0eaff2c292644c93ec513b7d5c/ui/app_list/views/search_result_page_view.h

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment