invalid presubmit error "OS_CHROMEOS macro is used without including build/build_config.h" |
|||
Issue descriptionAs I understand it, the OS_CHROMEOS macro is not defined in a particular header file (it's definitely not in "build/build_config.h"). It is provided to clang by gn directly: https://cs.chromium.org/chromium/src/build/config/linux/BUILD.gn?type=cs&q=defines.*%22os_chromeos%22&sq=package:chromium&l=26 PRESUBMIT.py assumes *any* macro that begins with "OS_" must be defined in build/build_config.h and requires including that header. But OS_CHROMEOS does not require that header. Correct me if I'm wrong, please!
,
Jul 14 2017
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79ef8f84b57e5432b36e5b6ee2affebf63062295 commit 79ef8f84b57e5432b36e5b6ee2affebf63062295 Author: Kent Tamura <tkent@chromium.org> Date: Tue Jul 18 00:00:21 2017 Update _CheckBuildConfigMacrosWithoutInclude() so that it excludes OS_CHROMEOS. Bug: 742692 Change-Id: I3a64ed5870d6a1769bfccab353ad261ce24de17d Reviewed-on: https://chromium-review.googlesource.com/571521 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#487294} [modify] https://crrev.com/79ef8f84b57e5432b36e5b6ee2affebf63062295/PRESUBMIT.py
,
Jul 18 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tkent@chromium.org
, Jul 14 2017