Don't print out VIDIOC_ENUM_FMT error message in a log if it is at the end of enumeration loop |
|||
Issue descriptionSeparate VIDIO_ENUM_FMT issue from https://bugs.chromium.org/p/chromium/issues/detail?id=697733#c6 =================================================================== "SYS_ioctl: VIDIOC_ENUM_FMT(2): fd=X, ret=-1, errno=2" messages in the logs. These normally are not errors if we are at the end of enumeration loop and we get the final EINVAL return value to stop us from enumerating more (see https://www.linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/vidioc-enum-fmt.html?highlight=vidioc_enum_fmt). We should try to not print out these messages of failing VIDIOC_ENUM_FMT in such cases.
,
Jul 14 2017
,
Jul 20 2017
It turns out this error message was output in libv4lplugins, which is a chromiumos third party library. I will upload a patch to ignore when cmd is VIDIOC_ENUM_FMT and it returns VINVAL. The patch will be merged shortly. Code review link: https://chromium-review.googlesource.com/c/578529/
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/libv4lplugins/+/cfb9e18bc09d70e46ea8be34510729c005ec6906 commit cfb9e18bc09d70e46ea8be34510729c005ec6906 Author: Hirokazu Honda <hiroh@chromium.org> Date: Thu Jul 20 15:00:11 2017 Rockchip: Do not print out a SYS_ioctl error message at the end of VIDIOC_ENUM_FMT enumeration loop Do not print out SYS_ioctl error message, when cmd is VIDIOC_ENUM_FMT and it returns EINVAL. It would be at the end of enumeration loop. It is not a real error then. BUG= chromium:742688 TEST=VEA unittest on kevin Change-Id: I78802f0351fe145107e89b7b296e6b75eae2f350 Reviewed-on: https://chromium-review.googlesource.com/578529 Commit-Ready: Hirokazu Honda <hiroh@chromium.org> Tested-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> [modify] https://crrev.com/cfb9e18bc09d70e46ea8be34510729c005ec6906/libv4l-rockchip_v2/libv4l-encplugin-rockchip.c [modify] https://crrev.com/cfb9e18bc09d70e46ea8be34510729c005ec6906/libv4l-rockchip/libv4l-encplugin-rockchip.c
,
Jul 20 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by hiroh@chromium.org
, Jul 14 2017