New issue
Advanced search Search tips

Issue 742672 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Layout Test external/wpt/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/moving-documents.html is flaky

Project Member Reported by tkent@chromium.org, Jul 14 2017

Issue description

The following layout test is flaky on all platforms

external/wpt/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/moving-documents.html

Probable cause:
Unknown


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cf0f37f103adb9b963c9feb2f57674eadfab2fa

commit 8cf0f37f103adb9b963c9feb2f57674eadfab2fa
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jul 14 01:59:54 2017

Mark moving-documents.html flaky.

Bug= 742672 
TBR=kochi@chromium.org
NOTRY=true

Change-Id: I11b056184b38826439b995221d9a14b12bdd922e
Reviewed-on: https://chromium-review.googlesource.com/571341
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486628}
[modify] https://crrev.com/8cf0f37f103adb9b963c9feb2f57674eadfab2fa/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by tkent@chromium.org, Jul 14 2017

This looks a test bug.
The test assumes destIFrame won't be refreshed, but it should refresh according to the specification. If destIframe is refreshed before sourceIFrame refresh, the test fails.

Comment 3 by tkent@chromium.org, Jul 18 2017

Owner: tkent@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3999e9237e394259301d8aa124e60e3d86f59bf

commit d3999e9237e394259301d8aa124e60e3d86f59bf
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Jul 19 05:14:09 2017

[html] Fix flakiness of moving-documents.html.

The test expected destIFrame wasn't refreshed. According to the standard and
dynamic-append.html in the same directory, destIFrame should be refreshed, and
the test failed if destIFrame was refreshed before sourceIFrame.

This CL updates moving-documents.html:
 - It doesn't move a meta, but just remove it.
  This test doesn't need to test 'remove and add' because dynamic-append.html
  covers 'add' part.
 - Rename it to remove-from-document.html.

Bug:  742672 
Change-Id: I249ca81207d0e94621818bfcd1797e6772161e6a
Reviewed-on: https://chromium-review.googlesource.com/575293
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487760}
[modify] https://crrev.com/d3999e9237e394259301d8aa124e60e3d86f59bf/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/f2430c59b71c4a842226ec3f5024fe880ed95d6c/third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/moving-documents.html
[add] https://crrev.com/d3999e9237e394259301d8aa124e60e3d86f59bf/third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/remove-from-document.html

Comment 5 by tkent@chromium.org, Jul 19 2017

Status: Fixed (was: Started)

Sign in to add a comment