New issue
Advanced search Search tips

Issue 742665 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----

Blocking:
issue 742666



Sign in to add a comment

Shill support for OpenVPN.ExtraHosts

Project Member Reported by wlj@google.com, Jul 14 2017

Issue description

As discussed on email with stevenjb@ and cernekee@, we would like to enable support for multiple OpenVPN servers, which will allow the OpenVPN client to fallback to multiple servers in the event the primary server is unavailable.
 
Cc: steve...@chromium.org
Labels: OS-Chrome
Blocking: 742666

Comment 3 by wlj@google.com, Aug 8 2017

@cernekee, what sort of timeline are we looking at to get this? Is there anything I can do to help with prioritization? TIA!

Comment 4 by wlj@google.com, Aug 21 2017

Ping
Components: Internals>Network>VPN
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/106eeed3635eef25a103c5fc27ce237854d27108

commit 106eeed3635eef25a103c5fc27ce237854d27108
Author: matthewmwang@chromium.org <matthewmwang@google.com>
Date: Wed Oct 11 20:19:34 2017

wifi: system_api: adding constant for OpenVPN.ExtraHosts support

Adding kOpenVPNExtraHostsProperty constant

BUG= chromium:742665 
TEST=Unit tests still work

Change-Id: I65736b12f1746876c5bac7512b90917935105515
Reviewed-on: https://chromium-review.googlesource.com/693285
Commit-Ready: Matthew Wang <matthewmwang@chromium.org>
Tested-by: Matthew Wang <matthewmwang@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>

[modify] https://crrev.com/106eeed3635eef25a103c5fc27ce237854d27108/dbus/shill/dbus-constants.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/f50f324b47f9564ec97dff745193eac669f85875

commit f50f324b47f9564ec97dff745193eac669f85875
Author: matthewmwang@chromium.org <matthewmwang@google.com>
Date: Fri Oct 13 07:27:34 2017

shill: vpn: Shill support for OpenVPN.ExtraHosts + unit tests

Adds OpenVPN support for fallback to multiple servers if primary
server is unavailable. This functionality is invoked when the
--remote option is found more than once.

BUG= chromium:742665 
TEST=Unit tests still work
CQ-DEPEND=CL:693285

Change-Id: I1af9d474dd28c51cc3fa66463f958fcf1e17f433
Reviewed-on: https://chromium-review.googlesource.com/692990
Commit-Ready: Matthew Wang <matthewmwang@chromium.org>
Tested-by: Matthew Wang <matthewmwang@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>

[modify] https://crrev.com/f50f324b47f9564ec97dff745193eac669f85875/vpn/openvpn_driver.h
[modify] https://crrev.com/f50f324b47f9564ec97dff745193eac669f85875/vpn/openvpn_driver.cc
[modify] https://crrev.com/f50f324b47f9564ec97dff745193eac669f85875/doc/service-api.txt
[modify] https://crrev.com/f50f324b47f9564ec97dff745193eac669f85875/vpn/openvpn_driver_unittest.cc

Labels: -Restrict-View-Google
Owner: matthewmwang@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment