New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742656 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Request to add UI>Browser>Extensions Component

Project Member Reported by dschuyler@chromium.org, Jul 14 2017

Issue description

There are existing components for 

UI>Browser>Bookmarks
UI>Browser>Downloads

which are separate chrome:// pages. In a similar fashion a 

UI>Browser>Extensions

would help us organize chrome://extensions bugs.
 
Components: -Admin>ComponentRequest
Do UI>Browser>Bookmarks and UI>Browser>Downloads refer to the webui page?  I would have thought it would be more native UI-related.  We have UI>Browser>WebUI, which is what I would think we'd use for all webui pages.  Can we either a) use UI>Browser>WebUI + labels or b) add UI>Browser>WebUI subcomponents (like downloads, extensions, etc)?
Components: Admin>ComponentRequest
Annnd... in trying to see what components we had, I removed the one this was using :)  Adding it back.

Comment 3 by dpa...@chromium.org, Jul 14 2017

It's unclear whether UI>Browser>Bookmarks, UI>Browser>Downloads refers to WebUI or native UI. Having said that, UI>Settings definitely refers to WebUI (see explanatory text in screenshot).

I am fine with either solution that allows finding MD Extensions related bugs easily. Something like the following query would be nice.

label:Proj-MaterialDesign-WebUI component:UI>Extensions 

Bonus: When MD extensions is the only extensions page left, we get to keep the same component (as opposed to having a UI>MDExtensions).
component_label.png
18.5 KB View Download
I'm up for (and happier to use) UI>Extensions

With UI>Browser>Extensions, I think it would also include native UI related to extensions (e.g., the extension toolbar, etc).  Now, that's not necessarily bad... but it wouldn't help with easy finding.  I think for easy finding, our best choices are either:
component:UI>Browser>WebUI + component:Platform>Extensions
or
component:UI>Browser>WebUI>Extensions
(using subcomponents of WebUI).

If we want to restrict it to webui-related stuff, I think webui should be specifically mentioned.

But, just my $0.02, and crbug experts may have different advice (which I'd be happy to defer to)
Cc: tsergeant@chromium.org
Sometime in the period since this bug was filed, UI>Browser>History, UI>Browser>Bookmarks and many others from UI>Browser have been moved to be children of UI>Extensions.

Could this have been part of the changes made here?
ui_extensions.png
43.5 KB View Download

Comment 7 by engedy@chromium.org, Jul 14 2017

Re #6: That's the working hypothesis in  Issue 742942 .
#6 & #7 that has since been reverted.
We already have Platform>Extensions, adding UI>Browser>Extensions would add confusion.

Bookmarks, Downloads, and History refer to the user feature and not the WebUI.
#9 Thanks for the information.

UI>Settings says that it refers to webui (and we've used it for webui).
Would UI>Extensions make sense for webui?
UI>Extensions still sounds like it should include native UI for extensions, which we probably don't want to have for webui.

Is there a reason we can't use the existing WebUI component?
I may be approaching this from the wrong direction. Rather than my asking for Component X or Y, let me ask:

Which component would convey that a bug is related to the chrome://extensions webui*? If there is not one, please consider adding one that we may use.

In a similar way to the UI>Settings referring to the chrome://settings webui.
My vote:
Component: UI>Browser>WebUI>Extensions

It seems to be the least confusing (it seems to clearly refer to the extensions WebUI, and I don't think it can refer to anything else).

But, just my $0.02.
While UI>Browser>WebUI>Extensions is longer than I was hoping for, it would allow several engineers, PM, UX, and QA on this project to organize/filter bugs more efficiently. Unless there's a shorter option, this is okay.

What is the next step on adding a component label?

How about UI>Browser>ExtensionManagement with the description "Management of Chrome Extension at chrome://extensions"?

Autocomplete would register when someone starts typing Ext.. (as it would for the other label) and would be clearly unambiguous to bug filers.  Distinguishing between UI work and plumbing/ developer APIs.
The suggestion by rdevlin.cronin@ in #13 seems the most on-target imo.
Though UI>Browser>ExtensionManagement is okay with me.
Owner: lafo...@chromium.org
Status: Fixed (was: Untriaged)
Created UI>Browser>ExtensionManagement.

We try and keep the component names, under UI, to be feature descriptive (i.e. understandable to laymen/ end users).  

WebUI, while correct from a hierarchy perspective, is more of a developer concept.

Sign in to add a comment