New issue
Advanced search Search tips

Issue 742646 link

Starred by 1 user
Status: Fixed
Owner:
michae...@chromium.org
Closed: Jul 2017
Cc:
rdevlin....@chromium.org
r...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 675413



Sign in to add a comment

AppShell: Load extensions from command lilne

Project Member Reported by michae...@chromium.org, Jul 14 2017 
AppShell should be able to load extensions from the command line instead of only loading apps.

This just requires some boilerplate in //extensions/shell. However, once we enable loading extensions, we should also use this opportunity to hunt for important pieces of the extensions system that might not be loaded or used properly in AppShell.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b158f3f3b1820df37a99d44600b5dc9d8a7b5f88

commit b158f3f3b1820df37a99d44600b5dc9d8a7b5f88
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Mon Jul 17 19:53:44 2017

Move --load-extensions from //chrome to //extensions

Just moving the switch to a common location.

TBR=bradnelson@chromium.org

Bug:  742646 
Change-Id: Ia537de1f26cf3a065d97f4fe2dca0256ab3ce0c5
Reviewed-on: https://chromium-review.googlesource.com/570888
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487204}
[modify] https://crrev.com/b158f3f3b1820df37a99d44600b5dc9d8a7b5f88/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/b158f3f3b1820df37a99d44600b5dc9d8a7b5f88/chrome/browser/extensions/extension_startup_browsertest.cc
[modify] https://crrev.com/b158f3f3b1820df37a99d44600b5dc9d8a7b5f88/chrome/common/chrome_switches.cc
[modify] https://crrev.com/b158f3f3b1820df37a99d44600b5dc9d8a7b5f88/chrome/common/chrome_switches.h
[modify] https://crrev.com/b158f3f3b1820df37a99d44600b5dc9d8a7b5f88/chrome/test/nacl/nacl_browsertest_util.cc
[modify] https://crrev.com/b158f3f3b1820df37a99d44600b5dc9d8a7b5f88/extensions/common/switches.cc
[modify] https://crrev.com/b158f3f3b1820df37a99d44600b5dc9d8a7b5f88/extensions/common/switches.h
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c464b9768844aaf2ef8f37ab9965bde45e690326

commit c464b9768844aaf2ef8f37ab9965bde45e690326
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Tue Jul 18 05:42:39 2017

Load extensions in AppShell

Loading an extension is just like loading a platform app (but without
sending a launch event). So we can support --load-extension in
AppShell.

Also call extension_system->Init() unconditionally.

NOPRESUBMIT=true # existing ScopedAllowIO test usage is allowed

Bug:  742646 
Change-Id: Id3c2adbebddc62d22953399f98e781229bda6d2b
Reviewed-on: https://chromium-review.googlesource.com/570809
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487394}
[modify] https://crrev.com/c464b9768844aaf2ef8f37ab9965bde45e690326/extensions/shell/browser/default_shell_browser_main_delegate.cc
[modify] https://crrev.com/c464b9768844aaf2ef8f37ab9965bde45e690326/extensions/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/c464b9768844aaf2ef8f37ab9965bde45e690326/extensions/shell/browser/shell_browsertest.cc
[modify] https://crrev.com/c464b9768844aaf2ef8f37ab9965bde45e690326/extensions/shell/browser/shell_extension_system.cc
[modify] https://crrev.com/c464b9768844aaf2ef8f37ab9965bde45e690326/extensions/shell/browser/shell_extension_system.h
[modify] https://crrev.com/c464b9768844aaf2ef8f37ab9965bde45e690326/extensions/shell/test/shell_apitest.cc
[modify] https://crrev.com/c464b9768844aaf2ef8f37ab9965bde45e690326/extensions/shell/test/shell_apitest.h
[add] https://crrev.com/c464b9768844aaf2ef8f37ab9965bde45e690326/extensions/test/data/extension/background.js
[add] https://crrev.com/c464b9768844aaf2ef8f37ab9965bde45e690326/extensions/test/data/extension/manifest.json

Comment 3 by michae...@chromium.org, Jul 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment