New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742627 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

CCT should only open for main frame webapp navigations

Project Member Reported by pkotw...@chromium.org, Jul 13 2017

Issue description

CCT should only open for main frame webapp navigations

I can't think of a scenario where opening the CCT as a result of an <iframe> navigation would cause unexpected behavior. Most sites have cross origin <iframe>s for ads. Usually (always?) those <iframe>s do a main frame navigation

 
I thought of this when I was looking through the implementation of InterceptNavigationDelegateImpl#showIgnoreNavigation() in order to respond to your earlier question

Comment 2 by piotrs@chromium.org, Jul 14 2017

Status: Started (was: Assigned)

Comment 3 by piotrs@chromium.org, Jul 14 2017

Status: WontFix (was: Started)
I tried it and we don't open CCT for URLs in iframes. Have you seen the case of us doing so?

Ideally I would add a test for it, but there is a technical issue. All pages I serve from the test server are in scope of the webapp, and all big pages I can rely on (e.g. google.com) have X-Frame-Options set to disable iframing. Therefore it's hard to perform off-origin navigation in an iframe in test. This will be easier once we roll out WebAPKs which have more fine grained scope.
Sorry for sending you down a rabbit hole. I was wrong.

InterceptNavigationDelegateImpl#shouldIgnoreNavigation() only gets called for non http <iframe> navigations. Those get filtered out in WebappInterceptNavigationDelegate via UrlUtilities#isValidForIntentFallbackNavigation()

Sign in to add a comment