CCT should only open for main frame webapp navigations |
|||
Issue descriptionCCT should only open for main frame webapp navigations I can't think of a scenario where opening the CCT as a result of an <iframe> navigation would cause unexpected behavior. Most sites have cross origin <iframe>s for ads. Usually (always?) those <iframe>s do a main frame navigation
,
Jul 14 2017
,
Jul 14 2017
I tried it and we don't open CCT for URLs in iframes. Have you seen the case of us doing so? Ideally I would add a test for it, but there is a technical issue. All pages I serve from the test server are in scope of the webapp, and all big pages I can rely on (e.g. google.com) have X-Frame-Options set to disable iframing. Therefore it's hard to perform off-origin navigation in an iframe in test. This will be easier once we roll out WebAPKs which have more fine grained scope.
,
Jul 14 2017
Sorry for sending you down a rabbit hole. I was wrong. InterceptNavigationDelegateImpl#shouldIgnoreNavigation() only gets called for non http <iframe> navigations. Those get filtered out in WebappInterceptNavigationDelegate via UrlUtilities#isValidForIntentFallbackNavigation() |
|||
►
Sign in to add a comment |
|||
Comment 1 by pkotw...@chromium.org
, Jul 13 2017